All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: govinds@codeaurora.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
Date: Thu, 20 Dec 2018 09:43:26 -0800	[thread overview]
Message-ID: <20181220174324.GA67805@google.com> (raw)
In-Reply-To: <87h8f8talw.fsf@kamboji.qca.qualcomm.com>

On Thu, Dec 20, 2018 at 06:40:43PM +0200, Kalle Valo wrote:
> Brian Norris <briannorris@chromium.org> writes:
> > Alternatively, you could add these ignored commands to wmi-tlv.h, and
> > just ignore them specifically. That's better documentation, in case
> > new WMI events come along that *are* important to notice when we
> > ignore them. There are other recent examples of that sort of patch
> > being merged.
> 
> I have actually tried to do that (what Brian describes above) during the
> last years but the problem is that there are just so many different
> firmware branches that it's difficult to keep up in ath10k. So in the
> end these warnings just confused the users and they mistakenly thought
> this warning message is the cause of their problems. That's why I think
> it's best to remove this warning.

Thanks for the background. To be clear, I'm perfectly fine with this
patch too. I was mostly just volunteering an alternative, in case it
*was* your intention as maintainer to keep it this way.

Regards,
Brian

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: govinds@codeaurora.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
Date: Thu, 20 Dec 2018 09:43:26 -0800	[thread overview]
Message-ID: <20181220174324.GA67805@google.com> (raw)
In-Reply-To: <87h8f8talw.fsf@kamboji.qca.qualcomm.com>

On Thu, Dec 20, 2018 at 06:40:43PM +0200, Kalle Valo wrote:
> Brian Norris <briannorris@chromium.org> writes:
> > Alternatively, you could add these ignored commands to wmi-tlv.h, and
> > just ignore them specifically. That's better documentation, in case
> > new WMI events come along that *are* important to notice when we
> > ignore them. There are other recent examples of that sort of patch
> > being merged.
> 
> I have actually tried to do that (what Brian describes above) during the
> last years but the problem is that there are just so many different
> firmware branches that it's difficult to keep up in ath10k. So in the
> end these warnings just confused the users and they mistakenly thought
> this warning message is the cause of their problems. That's why I think
> it's best to remove this warning.

Thanks for the background. To be clear, I'm perfectly fine with this
patch too. I was mostly just volunteering an alternative, in case it
*was* your intention as maintainer to keep it this way.

Regards,
Brian

  reply	other threads:[~2018-12-20 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  4:25 [PATCH] ath10k: Move non-fatal warn logs to dbg level Govind Singh
2018-11-29  4:25 ` Govind Singh
2018-11-30 20:59 ` Brian Norris
2018-11-30 20:59   ` Brian Norris
2018-12-20 16:40   ` Kalle Valo
2018-12-20 16:40     ` Kalle Valo
2018-12-20 17:43     ` Brian Norris [this message]
2018-12-20 17:43       ` Brian Norris
2018-12-20 17:06 ` Kalle Valo
2018-12-20 17:06 ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2019-11-25 13:10 [PATCH] ath10k: move " Govind Singh
2019-11-25 13:10 Govind Singh
2019-11-27 15:48 ` Kalle Valo
2019-11-27 15:48 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181220174324.GA67805@google.com \
    --to=briannorris@chromium.org \
    --cc=ath10k@lists.infradead.org \
    --cc=govinds@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.