* RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 6:01 ` Yoshihiro Shimoda
0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2018-12-14 6:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Fabrizio Castro, Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
>
> Document RZ/G2E (R8A774C0) SoC bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
By the way, I'm not sure, but I'm wondering that we need to add
.compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
What do you think?
Best regards,
Yoshihiro Shimoda
> ---
> Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 90719f5..d93b6a1 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -7,6 +7,7 @@ Required properties:
> - "renesas,usbhs-r8a7744" for r8a7744 (RZ/G1N) compatible device
> - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
> - "renesas,usbhs-r8a774a1" for r8a774a1 (RZ/G2M) compatible device
> + - "renesas,usbhs-r8a774c0" for r8a774c0 (RZ/G2E) compatible device
> - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> --
> 2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 6:01 ` Yoshihiro Shimoda
0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2018-12-14 6:01 UTC (permalink / raw)
To: Fabrizio Castro, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
>
> Document RZ/G2E (R8A774C0) SoC bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
By the way, I'm not sure, but I'm wondering that we need to add
.compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
What do you think?
Best regards,
Yoshihiro Shimoda
> ---
> Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 90719f5..d93b6a1 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -7,6 +7,7 @@ Required properties:
> - "renesas,usbhs-r8a7744" for r8a7744 (RZ/G1N) compatible device
> - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
> - "renesas,usbhs-r8a774a1" for r8a774a1 (RZ/G2M) compatible device
> + - "renesas,usbhs-r8a774c0" for r8a774c0 (RZ/G2E) compatible device
> - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> --
> 2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 8:15 ` Fabrizio Castro
0 siblings, 0 replies; 16+ messages in thread
From: Fabrizio Castro @ 2018-12-14 8:15 UTC (permalink / raw)
To: Yoshihiro Shimoda, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hello Yoshihiro-san,
Thank you for your feedback!
> From: Yoshihiro Shimoda
> Sent: 14 December 2018 06:01
> Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
>
> Hi Fabrizio,
>
> > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> >
> > Document RZ/G2E (R8A774C0) SoC bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Thank you for the patch!
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> By the way, I'm not sure, but I'm wondering that we need to add
> .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> What do you think?
Yeah, you are right, I am going to send a patch for that shortly.
Thanks,
Fab
>
> Best regards,
> Yoshihiro Shimoda
>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > index 90719f5..d93b6a1 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > @@ -7,6 +7,7 @@ Required properties:
> > - "renesas,usbhs-r8a7744" for r8a7744 (RZ/G1N) compatible device
> > - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
> > - "renesas,usbhs-r8a774a1" for r8a774a1 (RZ/G2M) compatible device
> > +- "renesas,usbhs-r8a774c0" for r8a774c0 (RZ/G2E) compatible device
> > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> > - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> > --
> > 2.7.4
[https://www2.renesas.eu/media/email/unicef.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 16+ messages in thread
* dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 8:15 ` Fabrizio Castro
0 siblings, 0 replies; 16+ messages in thread
From: Fabrizio Castro @ 2018-12-14 8:15 UTC (permalink / raw)
To: Yoshihiro Shimoda, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hello Yoshihiro-san,
Thank you for your feedback!
> From: Yoshihiro Shimoda
> Sent: 14 December 2018 06:01
> Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
>
> Hi Fabrizio,
>
> > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> >
> > Document RZ/G2E (R8A774C0) SoC bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Thank you for the patch!
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> By the way, I'm not sure, but I'm wondering that we need to add
> .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> What do you think?
Yeah, you are right, I am going to send a patch for that shortly.
Thanks,
Fab
>
> Best regards,
> Yoshihiro Shimoda
>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > index 90719f5..d93b6a1 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > @@ -7,6 +7,7 @@ Required properties:
> > - "renesas,usbhs-r8a7744" for r8a7744 (RZ/G1N) compatible device
> > - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
> > - "renesas,usbhs-r8a774a1" for r8a774a1 (RZ/G2M) compatible device
> > +- "renesas,usbhs-r8a774c0" for r8a774c0 (RZ/G2E) compatible device
> > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> > - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> > --
> > 2.7.4
[https://www2.renesas.eu/media/email/unicef.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 9:15 ` Yoshihiro Shimoda
0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2018-12-14 9:15 UTC (permalink / raw)
To: Fabrizio Castro, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hello Fabrizio-san,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM
>
> Hello Yoshihiro-san,
>
> Thank you for your feedback!
>
> > From: Yoshihiro Shimoda
> > Sent: 14 December 2018 06:01
> > Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
> >
> > Hi Fabrizio,
> >
> > > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> > >
> > > Document RZ/G2E (R8A774C0) SoC bindings.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Thank you for the patch!
> >
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > By the way, I'm not sure, but I'm wondering that we need to add
> > .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> > like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> > What do you think?
>
> Yeah, you are right, I am going to send a patch for that shortly.
Thank you for submitting a patch!
I have reviewed you patch and submitted my Acked-by.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 16+ messages in thread
* dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 9:15 ` Yoshihiro Shimoda
0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2018-12-14 9:15 UTC (permalink / raw)
To: Fabrizio Castro, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Hello Fabrizio-san,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM
>
> Hello Yoshihiro-san,
>
> Thank you for your feedback!
>
> > From: Yoshihiro Shimoda
> > Sent: 14 December 2018 06:01
> > Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
> >
> > Hi Fabrizio,
> >
> > > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> > >
> > > Document RZ/G2E (R8A774C0) SoC bindings.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Thank you for the patch!
> >
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > By the way, I'm not sure, but I'm wondering that we need to add
> > .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> > like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> > What do you think?
>
> Yeah, you are right, I am going to send a patch for that shortly.
Thank you for submitting a patch!
I have reviewed you patch and submitted my Acked-by.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 9:37 ` Fabrizio Castro
0 siblings, 0 replies; 16+ messages in thread
From: Fabrizio Castro @ 2018-12-14 9:37 UTC (permalink / raw)
To: Yoshihiro Shimoda, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Thank you Yoshihiro-san
> From: Yoshihiro Shimoda
> Sent: 14 December 2018 09:15
> Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
>
> Hello Fabrizio-san,
>
> > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM
> >
> > Hello Yoshihiro-san,
> >
> > Thank you for your feedback!
> >
> > > From: Yoshihiro Shimoda
> > > Sent: 14 December 2018 06:01
> > > Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
> > >
> > > Hi Fabrizio,
> > >
> > > > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> > > >
> > > > Document RZ/G2E (R8A774C0) SoC bindings.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Thank you for the patch!
> > >
> > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > >
> > > By the way, I'm not sure, but I'm wondering that we need to add
> > > .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> > > like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> > > What do you think?
> >
> > Yeah, you are right, I am going to send a patch for that shortly.
>
> Thank you for submitting a patch!
> I have reviewed you patch and submitted my Acked-by.
>
> Best regards,
> Yoshihiro Shimoda
[https://www2.renesas.eu/media/email/unicef.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 16+ messages in thread
* dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
@ 2018-12-14 9:37 ` Fabrizio Castro
0 siblings, 0 replies; 16+ messages in thread
From: Fabrizio Castro @ 2018-12-14 9:37 UTC (permalink / raw)
To: Yoshihiro Shimoda, Rob Herring, Mark Rutland
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc@vger.kernel.org
Thank you Yoshihiro-san
> From: Yoshihiro Shimoda
> Sent: 14 December 2018 09:15
> Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
>
> Hello Fabrizio-san,
>
> > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM
> >
> > Hello Yoshihiro-san,
> >
> > Thank you for your feedback!
> >
> > > From: Yoshihiro Shimoda
> > > Sent: 14 December 2018 06:01
> > > Subject: RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support
> > >
> > > Hi Fabrizio,
> > >
> > > > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
> > > >
> > > > Document RZ/G2E (R8A774C0) SoC bindings.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Thank you for the patch!
> > >
> > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > >
> > > By the way, I'm not sure, but I'm wondering that we need to add
> > > .compatible renesas,usbhs-r8a774c0 with .data USBHS_TYPE_RCAR_GEN3_WITH_PLL
> > > like r8a77990 to the drivers/usb/renesas_usbhs/common.c.
> > > What do you think?
> >
> > Yeah, you are right, I am going to send a patch for that shortly.
>
> Thank you for submitting a patch!
> I have reviewed you patch and submitted my Acked-by.
>
> Best regards,
> Yoshihiro Shimoda
[https://www2.renesas.eu/media/email/unicef.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 16+ messages in thread
