All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: devicetree@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
Date: Thu, 20 Dec 2018 15:44:47 -0600	[thread overview]
Message-ID: <20181220214447.GA18008@bogus> (raw)
In-Reply-To: <20181217153706.25873-2-marek.behun@nic.cz>

On Mon, Dec 17, 2018 at 04:37:05PM +0100, Marek Behún wrote:
> This adds device tree binding documentation for the rWTM BIU mailbox
> driver on the Armada 37xx SOC (EspressoBin, Turris Mox).
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
>  .../mailbox/armada-37xx-rwtm-mailbox.txt         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> new file mode 100644
> index 000000000000..2d182d61eb3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> @@ -0,0 +1,16 @@
> +* rWTM BIU Mailbox driver for Armada 37xx
> +
> +Required properties:
> +- compatible :	must be "marvell,armada-37xx-rwtm-mailbox"

Don't use wildcards in compatible strings.

> +- reg : 	physical base address of the mailbox and length of memory mapped

mixed space and tab.

> +		region
> +- interrupts:	the IRQ line for the mailbox
> +- #mbox-cells:	must be 1
> +
> +Example:
> +	rwtm: mailbox@b0000 {
> +		compatible = "marvell,armada-37xx-rwtm-mailbox";
> +		reg = <0xb0000 0x100>;
> +		interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +		#mbox-cells = <1>;
> +	};
> -- 
> 2.18.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
Date: Thu, 20 Dec 2018 15:44:47 -0600	[thread overview]
Message-ID: <20181220214447.GA18008@bogus> (raw)
In-Reply-To: <20181217153706.25873-2-marek.behun@nic.cz>

On Mon, Dec 17, 2018 at 04:37:05PM +0100, Marek Behún wrote:
> This adds device tree binding documentation for the rWTM BIU mailbox
> driver on the Armada 37xx SOC (EspressoBin, Turris Mox).
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
>  .../mailbox/armada-37xx-rwtm-mailbox.txt         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> new file mode 100644
> index 000000000000..2d182d61eb3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> @@ -0,0 +1,16 @@
> +* rWTM BIU Mailbox driver for Armada 37xx
> +
> +Required properties:
> +- compatible :	must be "marvell,armada-37xx-rwtm-mailbox"

Don't use wildcards in compatible strings.

> +- reg : 	physical base address of the mailbox and length of memory mapped

mixed space and tab.

> +		region
> +- interrupts:	the IRQ line for the mailbox
> +- #mbox-cells:	must be 1
> +
> +Example:
> +	rwtm: mailbox@b0000 {
> +		compatible = "marvell,armada-37xx-rwtm-mailbox";
> +		reg = <0xb0000 0x100>;
> +		interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +		#mbox-cells = <1>;
> +	};
> -- 
> 2.18.1
> 

  reply	other threads:[~2018-12-20 21:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 15:37 [PATCH v1 1/3] mailbox: Add support for Armada 37xx rWTM mailbox Marek Behún
2018-12-17 15:37 ` Marek Behún
2018-12-17 15:37 ` [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding Marek Behún
2018-12-17 15:37   ` Marek Behún
2018-12-20 21:44   ` Rob Herring [this message]
2018-12-20 21:44     ` Rob Herring
2018-12-20 22:08     ` Marek Behun
2018-12-20 22:08       ` Marek Behun
2018-12-21  5:13       ` Baruch Siach
2018-12-21  5:13         ` Baruch Siach
2018-12-17 15:37 ` [PATCH v1 3/3] arm64: dts: marvell: armada-37xx: add mailbox node Marek Behún
2018-12-17 15:37   ` Marek Behún
2018-12-18 14:56 ` [PATCH v1 1/3] mailbox: Add support for Armada 37xx rWTM mailbox kbuild test robot
2018-12-19 15:31 ` Marek Behún
2018-12-19 15:31   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181220214447.GA18008@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.