All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: matthias.bgg@gmail.com, lee.jones@linaro.org,
	chen.zhong@mediatek.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH v2 -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
Date: Fri, 21 Dec 2018 00:46:40 -0800	[thread overview]
Message-ID: <20181221084640.GI211587@dtor-ws> (raw)
In-Reply-To: <20181211093200.18140-1-yuehaibing@huawei.com>

On Tue, Dec 11, 2018 at 05:32:00PM +0800, YueHaibing wrote:
> alphabetise the header files and remove duplicated include
> file linux/kernel.h
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thank you.

> ---
> v2: alphabetise the header files
> ---
>  drivers/input/keyboard/mtk-pmic-keys.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> index 02c67a1..8e6ebab 100644
> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> @@ -14,18 +14,17 @@
>   *
>   */
>  
> -#include <linux/module.h>
> -#include <linux/kernel.h>
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
> -#include <linux/platform_device.h>
>  #include <linux/kernel.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> -#include <linux/regmap.h>
>  #include <linux/mfd/mt6323/registers.h>
> -#include <linux/mfd/mt6397/registers.h>
>  #include <linux/mfd/mt6397/core.h>
> +#include <linux/mfd/mt6397/registers.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
>  
>  #define MTK_PMIC_PWRKEY_RST_EN_MASK	0x1
>  #define MTK_PMIC_PWRKEY_RST_EN_SHIFT	6
> -- 
> 2.7.4
> 
> 

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org,
	matthias.bgg@gmail.com, chen.zhong@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
Date: Fri, 21 Dec 2018 00:46:40 -0800	[thread overview]
Message-ID: <20181221084640.GI211587@dtor-ws> (raw)
In-Reply-To: <20181211093200.18140-1-yuehaibing@huawei.com>

On Tue, Dec 11, 2018 at 05:32:00PM +0800, YueHaibing wrote:
> alphabetise the header files and remove duplicated include
> file linux/kernel.h
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thank you.

> ---
> v2: alphabetise the header files
> ---
>  drivers/input/keyboard/mtk-pmic-keys.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> index 02c67a1..8e6ebab 100644
> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> @@ -14,18 +14,17 @@
>   *
>   */
>  
> -#include <linux/module.h>
> -#include <linux/kernel.h>
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
> -#include <linux/platform_device.h>
>  #include <linux/kernel.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> -#include <linux/regmap.h>
>  #include <linux/mfd/mt6323/registers.h>
> -#include <linux/mfd/mt6397/registers.h>
>  #include <linux/mfd/mt6397/core.h>
> +#include <linux/mfd/mt6397/registers.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
>  
>  #define MTK_PMIC_PWRKEY_RST_EN_MASK	0x1
>  #define MTK_PMIC_PWRKEY_RST_EN_SHIFT	6
> -- 
> 2.7.4
> 
> 

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-21  8:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  9:32 [PATCH v2 -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c YueHaibing
2018-12-11  9:32 ` YueHaibing
2018-12-11  9:32 ` YueHaibing
2018-12-21  8:46 ` Dmitry Torokhov [this message]
2018-12-21  8:46   ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2018-12-11  9:21 YueHaibing
2018-12-11  9:28 ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181221084640.GI211587@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=chen.zhong@mediatek.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.