From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: gwendal@chromium.org, drinkcat@chromium.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
kernel@collabora.com, bleung@chromium.org
Subject: Re: [PATCH v5 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver
Date: Fri, 21 Dec 2018 09:09:12 +0000 [thread overview]
Message-ID: <20181221090912.GT4497@dell> (raw)
In-Reply-To: <20181212173402.27086-3-enric.balletbo@collabora.com>
On Wed, 12 Dec 2018, Enric Balletbo i Serra wrote:
> The entire way how cros sysfs attibutes are created is broken.
> cros_ec_lightbar should be its own driver and its attributes should be
> associated with a lightbar driver not the mfd driver. In order to retain
> the path, the lightbar attributes are attached to the cros_class.
>
> The patch also adds the sysfs documentation.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> Changes in v5: None
> Changes in v4:
> - Use <ec-device-name> instead <cros-ec> in documentation.
>
> Changes in v3:
> - Removed unneded check for ec_dev.
>
> Changes in v2:
> - Removed the two exported functions to attach/detach to the cros_class.
> - Use dev_warn instead of dev_err when adding the lightbar.
>
> ...sfs-class-chromeos-driver-cros-ec-lightbar | 74 +++++++++++++++
> drivers/mfd/cros_ec_dev.c | 24 ++---
> drivers/mfd/cros_ec_dev.h | 6 --
> drivers/platform/chrome/Kconfig | 11 +++
> drivers/platform/chrome/Makefile | 3 +-
> drivers/platform/chrome/cros_ec_lightbar.c | 95 ++++++++++++++-----
> include/linux/mfd/cros_ec.h | 1 -
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-21 9:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 17:33 [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers Enric Balletbo i Serra
2018-12-12 17:33 ` [PATCH v5 1/7] mfd / platform: cros_ec: use devm_mfd_add_devices Enric Balletbo i Serra
2018-12-21 9:08 ` Lee Jones
2018-12-12 17:33 ` [PATCH v5 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver Enric Balletbo i Serra
2018-12-21 9:09 ` Lee Jones [this message]
2018-12-12 17:33 ` [PATCH v5 3/7] mfd / platform: cros_ec: move vbc " Enric Balletbo i Serra
2018-12-12 17:33 ` [PATCH v5 4/7] mfd / platform: cros_ec: move debugfs " Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 5/7] mfd / platform: cros_ec: move device sysfs " Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 6/7] mfd / platform: cros_ec_vbc: instantiate only if the EC has a VBC NVRAM Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar Enric Balletbo i Serra
2018-12-21 9:10 ` [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers Lee Jones
2019-01-08 16:21 ` Enric Balletbo Serra
2019-01-09 7:25 ` Lee Jones
2019-01-09 9:15 ` Enric Balletbo i Serra
2019-01-16 8:51 ` Lee Jones
2019-01-31 9:28 ` Enric Balletbo Serra
2019-02-01 8:19 ` Lee Jones
2019-02-01 8:19 ` [GIT PULL] Immutable branch between MFD and Platform due for the v5.1 merge window Lee Jones
2019-02-06 20:07 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221090912.GT4497@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.