From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Gwendal Grignou <gwendal@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
kernel@collabora.com, Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers.
Date: Wed, 9 Jan 2019 07:25:56 +0000 [thread overview]
Message-ID: <20190109072556.GD27286@dell> (raw)
In-Reply-To: <CAFqH_51mrsb=cBOeBL0avyYGogZ-MtMUpKUS7avXGT9Q2JmWHw@mail.gmail.com>
On Tue, 08 Jan 2019, Enric Balletbo Serra wrote:
> Missatge de Lee Jones <lee.jones@linaro.org> del dia dv., 21 de des.
> 2018 a les 16:39:
> >
> > On Wed, 12 Dec 2018, Enric Balletbo i Serra wrote:
> >
> > > Hi,
> > >
> > > This is another patchset to try to cleanup a bit more the crossed
> > > references for cros-ec driver between the MFD and the platform/chrome
> > > subsystems.
> > >
> > > The purpose of these patches is get rid of the different cros-ec attributes
> > > from mfd/cros_ec_dev to its own sub-driver in platform/chrome. cros_ec_dev
> > > continues instantiating the sub-devices but the sysfs attributes are owned
> > > by the platform driver.E.g. The lightbar driver should own his sysfs
> > > attributes and be instantiated only if the Embedded Controller has a
> > > lightbar.
> > >
> > > The patchset also adds the documentation of the sysfs attributes.
> > >
> > > Most of the patches touches mfd subsystem and platform/chrome so I'd
> > > suggest go all using and inmutable branch.
> >
> > That's fine.
> >
> > What else needs to happen with this set?
>
> I think the patchset is ready to be queued. Note that to apply cleanly
> it depends on [1] which is already merged in your for-next branch.
> What do you prefer, go through your repo or go through the
> chrome-platform repo? Do you want Benson or I create an immutable
> branch? I'm fine with whenever you decide.
Probably best if this goes through the MFD tree.
I have a PR pending upstream at the moment. Once I know what is
happening with that, I'll start taking patches/sets again.
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=18e294ddafaeb80a1e2e10c9bd750a6cb8388d5b
>
> > Any more Acks required?
> >
>
> I think that you, Guenter, Benson and I are fine with it, so not more
> acks needed.
Thanks for the clarification.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-01-09 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 17:33 [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers Enric Balletbo i Serra
2018-12-12 17:33 ` [PATCH v5 1/7] mfd / platform: cros_ec: use devm_mfd_add_devices Enric Balletbo i Serra
2018-12-21 9:08 ` Lee Jones
2018-12-12 17:33 ` [PATCH v5 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver Enric Balletbo i Serra
2018-12-21 9:09 ` Lee Jones
2018-12-12 17:33 ` [PATCH v5 3/7] mfd / platform: cros_ec: move vbc " Enric Balletbo i Serra
2018-12-12 17:33 ` [PATCH v5 4/7] mfd / platform: cros_ec: move debugfs " Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 5/7] mfd / platform: cros_ec: move device sysfs " Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 6/7] mfd / platform: cros_ec_vbc: instantiate only if the EC has a VBC NVRAM Enric Balletbo i Serra
2018-12-12 17:34 ` [PATCH v5 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar Enric Balletbo i Serra
2018-12-21 9:10 ` [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers Lee Jones
2019-01-08 16:21 ` Enric Balletbo Serra
2019-01-09 7:25 ` Lee Jones [this message]
2019-01-09 9:15 ` Enric Balletbo i Serra
2019-01-16 8:51 ` Lee Jones
2019-01-31 9:28 ` Enric Balletbo Serra
2019-02-01 8:19 ` Lee Jones
2019-02-01 8:19 ` [GIT PULL] Immutable branch between MFD and Platform due for the v5.1 merge window Lee Jones
2019-02-06 20:07 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109072556.GD27286@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=drinkcat@chromium.org \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.