From: Lee Jones <lee.jones@linaro.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
marcel.ziswiler@toradex.com, linux-kernel@vger.kernel.org,
stefan@agner.ch,
Philippe Schenker <philippe.schenker@toradex.com>,
thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org,
Max Krummenacher <max.krummenacher@toradex.com>,
linux-stm32@st-md-mailman.stormreply.com, jic23@kernel.org
Subject: Re: [PATCH v4 3/8] mfd: stmpe: preparations for STMPE ADC driver
Date: Fri, 21 Dec 2018 10:42:50 +0000 [thread overview]
Message-ID: <20181221104250.GM13248@dell> (raw)
In-Reply-To: <20181212130649.15146-3-dev@pschenker.ch>
On Wed, 12 Dec 2018, Philippe Schenker wrote:
> This prepares the MFD for the STMPE ADC driver. This commit introduces
> devicetree settings that are used by the ADC and adds an init function.
> Common ADC settings that are shared with the touchscreen driver can now
> reside in the overlying MFD.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
>
> I moved now all enables back to the subdevices. The disable of ADC
> block is now done at remove of mfd. I know this is not particularly
> right, the right way to do this would be with a refcounter.
>
> But I don't know how to implement this in this driver. If someone does
> not agree to disable adc in remove of mfd, please give me some advice
> in how to do it with refcounter.
>
> Changes in v4:
> - New patch: split mfd changes into this precursor patch
> - Export the added stmpe811_adc_commmon_init function
> - Disabling adc when mfd is removed
>
> Changes in v3: None
> Changes in v2:
> - Move code to setup ADC to MFD device, as it is used by both drivers
> adc and touchscreen
>
> drivers/mfd/Kconfig | 3 +-
> drivers/mfd/stmpe.c | 68 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/stmpe.h | 10 ++++++
> 3 files changed, 80 insertions(+), 1 deletion(-)
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: jic23@kernel.org, marcel.ziswiler@toradex.com, stefan@agner.ch,
thierry.reding@gmail.com,
Max Krummenacher <max.krummenacher@toradex.com>,
Philippe Schenker <philippe.schenker@toradex.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-kernel@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/8] mfd: stmpe: preparations for STMPE ADC driver
Date: Fri, 21 Dec 2018 10:42:50 +0000 [thread overview]
Message-ID: <20181221104250.GM13248@dell> (raw)
In-Reply-To: <20181212130649.15146-3-dev@pschenker.ch>
On Wed, 12 Dec 2018, Philippe Schenker wrote:
> This prepares the MFD for the STMPE ADC driver. This commit introduces
> devicetree settings that are used by the ADC and adds an init function.
> Common ADC settings that are shared with the touchscreen driver can now
> reside in the overlying MFD.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
>
> I moved now all enables back to the subdevices. The disable of ADC
> block is now done at remove of mfd. I know this is not particularly
> right, the right way to do this would be with a refcounter.
>
> But I don't know how to implement this in this driver. If someone does
> not agree to disable adc in remove of mfd, please give me some advice
> in how to do it with refcounter.
>
> Changes in v4:
> - New patch: split mfd changes into this precursor patch
> - Export the added stmpe811_adc_commmon_init function
> - Disabling adc when mfd is removed
>
> Changes in v3: None
> Changes in v2:
> - Move code to setup ADC to MFD device, as it is used by both drivers
> adc and touchscreen
>
> drivers/mfd/Kconfig | 3 +-
> drivers/mfd/stmpe.c | 68 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/stmpe.h | 10 ++++++
> 3 files changed, 80 insertions(+), 1 deletion(-)
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-21 10:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 13:06 [PATCH v4 1/8] dt-bindings: stmpe: reformatting parameter list and use tabs only Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-12 13:06 ` [PATCH v4 2/8] mfd: stmpe: Move ADC related defines to header of mfd Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-12 13:06 ` [PATCH v4 3/8] mfd: stmpe: preparations for STMPE ADC driver Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-21 10:42 ` Lee Jones [this message]
2018-12-21 10:42 ` Lee Jones
2018-12-12 13:06 ` [PATCH v4 4/8] Input: stmpe-ts: " Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-12 13:06 ` [PATCH v4 5/8] iio: adc: add STMPE ADC driver using IIO framework Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-16 12:24 ` Jonathan Cameron
2018-12-16 12:24 ` Jonathan Cameron
2018-12-12 13:06 ` [PATCH v4 6/8] iio: adc: add STMPE ADC devicetree bindings Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-16 12:28 ` Jonathan Cameron
2018-12-16 12:28 ` Jonathan Cameron
2018-12-17 22:15 ` Rob Herring
2018-12-17 22:15 ` Rob Herring
2018-12-12 13:06 ` [PATCH v4 7/8] ARM: dts: Add stmpe-adc DT node to Toradex iMX6 modules Philippe Schenker
2018-12-12 13:06 ` Philippe Schenker
2018-12-12 13:06 ` [PATCH v4 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker
2018-12-20 12:34 ` Dmitry Osipenko
2018-12-17 22:06 ` [PATCH v4 1/8] dt-bindings: stmpe: reformatting parameter list and use tabs only Rob Herring
2018-12-17 22:06 ` Rob Herring
2018-12-21 10:42 ` Lee Jones
2018-12-21 10:42 ` Lee Jones
2018-12-21 10:44 ` Lee Jones
2018-12-21 10:44 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221104250.GM13248@dell \
--to=lee.jones@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=dev@pschenker.ch \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.schenker@toradex.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.