From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)
Date: Sat, 22 Dec 2018 09:32:52 +0100 [thread overview]
Message-ID: <20181222083252.GV24194@scaer> (raw)
In-Reply-To: <df37a271-7012-b8d2-fc4d-edfa66a0e163@andin.de>
Andreas, All,
On 2018-12-21 10:46 +0100, Andreas Naumann spake thusly:
> Am 07.12.18 um 19:10 schrieb Yann E. MORIN:
> >This two-patch series is my counter-proposal to Joel's path to try and
> >fix the issue:
> > https://patchwork.ozlabs.org/patch/1009168/
> >
> >The first patch fixes the absolute symlinks, that were so far not
> >accounted for at all. A new helper scripts changes them into relative
> >symlinks.
> >
> >The second patch is the actual fix to the issue Joel's patch was trying
> >to solve. I believe it is a better and simpler solution, although I have
> >to admit the patsubst trickery is not obvious.
>
> Thank you for these patches as they adress an SDK issue I have just found.
> I have applied them on top of 2018.11 and verified the link ./usr -> ./
> remains as is and is not changed into a dead link to
> ./arm-buildroot-linux-gnueabihf_sdk-buildroot/.
>
> However, the check for symlinks pointing out of host/ showed to two issues
> originating in install steps of iptables and eudev. Both create links that
> point to system pathes.
Ok, thanks for the report! :-)
> I have locally made POST_STAGING_HOOKS to fix that but that's probably a non
> acceptable hack.
Indeed no, please see my reply to Joel's suggestion instead.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2018-12-22 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 18:10 [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk) Yann E. MORIN
2018-12-07 18:10 ` [Buildroot] [PATCH 1/2] core: make symlinks relative when preparing the SDK Yann E. MORIN
2018-12-07 19:35 ` Joel Carlson
2018-12-07 18:10 ` [Buildroot] [PATCH 2/2] core/sdk: don't mangle symlinks with '.' or '..' at start Yann E. MORIN
2018-12-07 19:39 ` Joel Carlson
2018-12-07 19:44 ` Yann E. MORIN
2018-12-21 9:46 ` [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk) Andreas Naumann
2018-12-22 0:13 ` Joel Carlson
2018-12-22 8:31 ` Yann E. MORIN
2018-12-22 18:21 ` Joel Carlson
2018-12-22 18:54 ` Yann E. MORIN
2018-12-26 18:22 ` Trent Piepho
2018-12-22 8:32 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222083252.GV24194@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.