All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)
Date: Sat, 22 Dec 2018 19:54:13 +0100	[thread overview]
Message-ID: <20181222185413.GW24194@scaer> (raw)
In-Reply-To: <CA+1k=2ay7v0G0pjwB4PTTR-6mH3_FueDiFi8D3rhbcZa35zq+g@mail.gmail.com>

Joel, All,

On 2018-12-22 11:21 -0700, Joel Carlson spake thusly:
> On Sat, Dec 22, 2018 at 1:31 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > I did nt see Thomas' reply to the iptables patch before I replied to
> > your eudev one. It turns out we basically said exactly the same thing:
> > this is not the correct solution.
> My apologies on submitting a bad patch.

Hey, no worries! :-)  That's what reviews are for.

> >   if it is a symlink:
> >       if is not below staging/:
> >           check and fix it
> >       else if it is below staging/{lib,usr/lib,usr/include}:
> >           check and fix it
> >       else
> >           ignore it
> >
> > I can try to look into fixing that in my series. Is enabling eudev
> > and/or iptables enough to echibit the problem?
> 
> That is a better solution. And yes, with the previous sdk fixes
> applied, just enabling eudev and/or iptables and then trying to 'make
> sdk' would error out because of the symlink path being outside of
> staging.

Yeah, I eventually managed to reproduce the issue, indeed. so I
submitted v3 of the series. Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-12-22 18:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 18:10 [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk) Yann E. MORIN
2018-12-07 18:10 ` [Buildroot] [PATCH 1/2] core: make symlinks relative when preparing the SDK Yann E. MORIN
2018-12-07 19:35   ` Joel Carlson
2018-12-07 18:10 ` [Buildroot] [PATCH 2/2] core/sdk: don't mangle symlinks with '.' or '..' at start Yann E. MORIN
2018-12-07 19:39   ` Joel Carlson
2018-12-07 19:44     ` Yann E. MORIN
2018-12-21  9:46 ` [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk) Andreas Naumann
2018-12-22  0:13   ` Joel Carlson
2018-12-22  8:31     ` Yann E. MORIN
2018-12-22 18:21       ` Joel Carlson
2018-12-22 18:54         ` Yann E. MORIN [this message]
2018-12-26 18:22         ` Trent Piepho
2018-12-22  8:32   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181222185413.GW24194@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.