From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: "Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org>
Cc: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
KISHON VIJAY ABRAHAM <kishon-l0cyMroinI0@public.gmane.org>,
"Mishol, Guy" <guym-l0cyMroinI0@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Anders Roxell
<anders.roxell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Ricardo Salveti
<rsalveti-3fX5ma9fJBTk1uMJSBkQmQ@public.gmane.org>
Subject: Re: [EXTERNAL] Re: [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly
Date: Sun, 23 Dec 2018 08:02:26 -0800 [thread overview]
Message-ID: <20181223160226.GK6707@atomide.com> (raw)
In-Reply-To: <c22e2ab61b494ea0852c0f4654fef92d-l0cyMroinI0@public.gmane.org>
Hi,
* Reizer, Eyal <eyalr-l0cyMroinI0@public.gmane.org> [181223 07:38]:
> You are ok as long as the wlan_enable pin Does go down for a sufficient amount of time
> turning the wl18xx device off.
> The firmware can only be downloaded once after power on.
> In between down/up you have to make sure the wlan_enable is fully going through on->off->on
> and the wl18xx device is fully reset.
> On power on the firmware is loaded by the driver and this will fail in case the reset didn't happen
OK thanks for confirming that it's the enable pin that needs to toggle.
Sounds like I need to get the wlcore pwrseq changes done and posted as
the long term solution.
And for a short term fix, we should just add msleep(50) for now with
updated patch description.
Does that that sound OK to everybody?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Reizer, Eyal" <eyalr@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
KISHON VIJAY ABRAHAM <kishon@ti.com>, "Mishol, Guy" <guym@ti.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Ricardo Salveti <rsalveti@rsalveti.net>
Subject: Re: [EXTERNAL] Re: [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly
Date: Sun, 23 Dec 2018 08:02:26 -0800 [thread overview]
Message-ID: <20181223160226.GK6707@atomide.com> (raw)
In-Reply-To: <c22e2ab61b494ea0852c0f4654fef92d@ti.com>
Hi,
* Reizer, Eyal <eyalr@ti.com> [181223 07:38]:
> You are ok as long as the wlan_enable pin Does go down for a sufficient amount of time
> turning the wl18xx device off.
> The firmware can only be downloaded once after power on.
> In between down/up you have to make sure the wlan_enable is fully going through on->off->on
> and the wl18xx device is fully reset.
> On power on the firmware is loaded by the driver and this will fail in case the reset didn't happen
OK thanks for confirming that it's the enable pin that needs to toggle.
Sounds like I need to get the wlcore pwrseq changes done and posted as
the long term solution.
And for a short term fix, we should just add msleep(50) for now with
updated patch description.
Does that that sound OK to everybody?
Regards,
Tony
next prev parent reply other threads:[~2018-12-23 16:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:42 [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly Tony Lindgren
2018-12-17 16:42 ` Tony Lindgren
[not found] ` <20181217164207.20081-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-18 1:06 ` Ricardo Salveti
2018-12-18 1:06 ` Ricardo Salveti
2018-12-18 12:34 ` Ulf Hansson
2018-12-18 12:34 ` Ulf Hansson
[not found] ` <CAPDyKFoLnNWsBfaUwqwL31J=zb0UOQjXUKi7Sj0AUsnNoC6bYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-18 15:54 ` Tony Lindgren
2018-12-18 15:54 ` Tony Lindgren
[not found] ` <20181218155439.GB6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-20 10:14 ` Ulf Hansson
2018-12-20 10:14 ` Ulf Hansson
[not found] ` <CAPDyKFr2xx6fmdgjd10C1jekWg-yZPk32fGWEPO2PyexjofJ1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-20 23:14 ` Tony Lindgren
2018-12-20 23:14 ` Tony Lindgren
[not found] ` <20181220231401.GG6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-23 7:38 ` [EXTERNAL] " Reizer, Eyal
2018-12-23 7:38 ` Reizer, Eyal
[not found] ` <c22e2ab61b494ea0852c0f4654fef92d-l0cyMroinI0@public.gmane.org>
2018-12-23 16:02 ` Tony Lindgren [this message]
2018-12-23 16:02 ` Tony Lindgren
[not found] ` <20181223160226.GK6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-28 11:01 ` Ulf Hansson
2018-12-28 11:01 ` Ulf Hansson
[not found] ` <CAPDyKFoEOGACs4Wnm7UgKab2b1-7+v8+31DpC+p=8XxcQhSpcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-28 19:59 ` Tony Lindgren
2018-12-28 19:59 ` Tony Lindgren
[not found] ` <20181228195903.GX6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2019-01-02 12:01 ` Ulf Hansson
2019-01-02 12:01 ` Ulf Hansson
[not found] ` <CAPDyKFq9XmRueJEFKVb03hqLuoB84TGjrdvEjre46ezYbk_wgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-07 15:18 ` Tony Lindgren
2019-01-07 15:18 ` Tony Lindgren
[not found] ` <20190107151849.GC5544-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2019-01-07 16:12 ` Kalle Valo
2019-01-07 16:12 ` Kalle Valo
[not found] ` <87k1jgsaze.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2019-01-14 13:47 ` Ulf Hansson
2019-01-14 13:47 ` Ulf Hansson
2018-12-28 9:48 ` Ulf Hansson
2018-12-28 9:48 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223160226.GK6707@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=anders.roxell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=eyalr-l0cyMroinI0@public.gmane.org \
--cc=guym-l0cyMroinI0@public.gmane.org \
--cc=john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rsalveti-3fX5ma9fJBTk1uMJSBkQmQ@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.