All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mt76: run mac work every 100ms
Date: Thu, 27 Dec 2018 11:54:10 +0100	[thread overview]
Message-ID: <20181227105410.GD25885@redhat.com> (raw)
In-Reply-To: <f28b63441e1a1c1518e28dc70ff7fc854ae60361.1545667662.git.lorenzo.bianconi@redhat.com>

On Mon, Dec 24, 2018 at 05:24:41PM +0100, Lorenzo Bianconi wrote:
> Introduce MT_WATCHDOG_TIME macro in order to run mac work every 100ms.
> This is a preliminary patch to implement a proper tx hang watchdog
<snip>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c b/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> index b54a32397486..ec936002a286 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> @@ -33,7 +33,7 @@ mt76x2_start(struct ieee80211_hw *hw)
>  		goto out;
>  
>  	ieee80211_queue_delayed_work(mt76_hw(dev), &dev->mac_work,
> -				     MT_CALIBRATE_INTERVAL);
> +				     MT_WATCHDOG_TIME);

There are other procedures that are performed on mac_work , which most
likely don't have to be done so frequently. I think watchdog should
be placed it it's own work.

Regards
Stanislaw


  reply	other threads:[~2018-12-27 10:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 16:24 [PATCH 0/2] introduce mt76 tx hang watchdog Lorenzo Bianconi
2018-12-24 16:24 ` [PATCH 1/2] mt76: run mac work every 100ms Lorenzo Bianconi
2018-12-27 10:54   ` Stanislaw Gruszka [this message]
2018-12-27 16:44     ` Lorenzo Bianconi
2018-12-24 16:24 ` [PATCH 2/2] mt76: introduce mt76x02_check_tx_hang watchdog Lorenzo Bianconi
2018-12-27 10:59   ` Stanislaw Gruszka
2018-12-27 16:41     ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181227105410.GD25885@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.