Re: [PATCH 2/2] mt76: introduce mt76x02_check_tx_hang watchdog

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Mon, Dec 24, 2018 at 05:24:42PM +0100, Lorenzo Bianconi wrote:
> Port mt76x02_check_tx_hang watchdog from vendor driver in order to
> perform a device reset when tx mac/dma logic hangs. Tx mac/dma stuck
> has been observed when the device is heavily loaded or in a noisy
> environment.

On what hardware this happen ? Is this only for AP mode?
 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> index a4ff5a7a219f..402944e81e5e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> @@ -778,6 +778,90 @@ static void mt76x02_check_mac_err(struct mt76x02_dev *dev)
>  		MT_MAC_SYS_CTRL_ENABLE_TX | MT_MAC_SYS_CTRL_ENABLE_RX);
>  }
>  
> +static void mt76x02_mac_watchdog_reset(struct mt76x02_dev *dev)

This all is MMIO specific, it should be moved to mt76x02_mmio.c

Regards 
Stanislaw