From: Cornelia Huck <cohuck@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com, borntraeger@de.ibm.com, pbonzini@redhat.com,
dgilbert@redhat.com
Subject: [virtio-dev] Re: [PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL
Date: Thu, 3 Jan 2019 10:59:16 +0100 [thread overview]
Message-ID: <20190103105916.3f3431c6.cohuck@redhat.com> (raw)
In-Reply-To: <1545963986-11280-3-git-send-email-wei.w.wang@intel.com>
On Fri, 28 Dec 2018 10:26:26 +0800
Wei Wang <wei.w.wang@intel.com> wrote:
> Some vqs may not need to be allocated when their related feature bits
> are disabled. So callers may pass in such vqs with "names = NULL".
s/=/==/ (here and in the subject)
> Then we skip such vq allocations.
>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> ---
> drivers/misc/mic/vop/vop_main.c | 9 +++++++--
> drivers/remoteproc/remoteproc_virtio.c | 9 +++++++--
> drivers/s390/virtio/virtio_ccw.c | 12 +++++++++---
> drivers/virtio/virtio_mmio.c | 9 +++++++--
> 4 files changed, 30 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com, borntraeger@de.ibm.com, pbonzini@redhat.com,
dgilbert@redhat.com
Subject: Re: [PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL
Date: Thu, 3 Jan 2019 10:59:16 +0100 [thread overview]
Message-ID: <20190103105916.3f3431c6.cohuck@redhat.com> (raw)
In-Reply-To: <1545963986-11280-3-git-send-email-wei.w.wang@intel.com>
On Fri, 28 Dec 2018 10:26:26 +0800
Wei Wang <wei.w.wang@intel.com> wrote:
> Some vqs may not need to be allocated when their related feature bits
> are disabled. So callers may pass in such vqs with "names = NULL".
s/=/==/ (here and in the subject)
> Then we skip such vq allocations.
>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> ---
> drivers/misc/mic/vop/vop_main.c | 9 +++++++--
> drivers/remoteproc/remoteproc_virtio.c | 9 +++++++--
> drivers/s390/virtio/virtio_ccw.c | 12 +++++++++---
> drivers/virtio/virtio_mmio.c | 9 +++++++--
> 4 files changed, 30 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-03 9:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 2:26 [virtio-dev] [PATCH v1 0/2] Virtio: fix some vq allocation issues Wei Wang
2018-12-28 2:26 ` Wei Wang
2018-12-28 2:26 ` [PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq Wei Wang
2018-12-28 2:26 ` [virtio-dev] " Wei Wang
2018-12-28 2:26 ` Wei Wang
2019-01-03 9:57 ` [virtio-dev] " Cornelia Huck
2019-01-03 9:57 ` Cornelia Huck
2019-01-03 9:57 ` Cornelia Huck
2019-01-09 16:29 ` [virtio-dev] " Christian Borntraeger
2019-01-09 16:29 ` Christian Borntraeger
2019-01-09 16:29 ` Christian Borntraeger
2018-12-28 2:26 ` [PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL Wei Wang
2018-12-28 2:26 ` [virtio-dev] " Wei Wang
2018-12-28 2:26 ` Wei Wang
2019-01-03 9:59 ` Cornelia Huck [this message]
2019-01-03 9:59 ` Cornelia Huck
2019-01-03 9:59 ` Cornelia Huck
2019-01-09 16:30 ` [virtio-dev] " Christian Borntraeger
2019-01-09 16:30 ` Christian Borntraeger
2019-01-09 16:30 ` Christian Borntraeger
2018-12-28 7:57 ` [virtio-dev] Re: [PATCH v1 0/2] Virtio: fix some vq allocation issues Christian Borntraeger
2018-12-28 7:57 ` Christian Borntraeger
2018-12-29 2:45 ` Wang, Wei W
2018-12-29 2:45 ` [virtio-dev] " Wang, Wei W
2018-12-29 2:45 ` Wang, Wei W
2018-12-30 6:06 ` [virtio-dev] " Halil Pasic
2018-12-30 6:06 ` Halil Pasic
2018-12-31 6:03 ` [virtio-dev] " Wang, Wei W
2018-12-31 6:03 ` Wang, Wei W
2018-12-31 6:03 ` Wang, Wei W
2018-12-31 23:40 ` [virtio-dev] " Halil Pasic
2018-12-31 23:40 ` Halil Pasic
2018-12-31 23:40 ` Halil Pasic
2019-01-02 9:53 ` [virtio-dev] " Cornelia Huck
2019-01-02 9:53 ` Cornelia Huck
2019-01-02 9:53 ` Cornelia Huck
2019-01-02 13:23 ` [virtio-dev] " Cornelia Huck
2019-01-02 13:23 ` Cornelia Huck
2019-01-02 13:23 ` Cornelia Huck
2019-01-02 13:23 ` Cornelia Huck
2019-01-02 15:59 ` [virtio-dev] " Halil Pasic
2019-01-02 15:59 ` Halil Pasic
2019-01-02 15:59 ` Halil Pasic
2019-01-02 18:02 ` [virtio-dev] " Cornelia Huck
2019-01-02 18:02 ` Cornelia Huck
2019-01-02 18:02 ` Cornelia Huck
2019-01-02 18:02 ` Cornelia Huck
2019-01-02 19:13 ` [virtio-dev] " Halil Pasic
2019-01-02 19:13 ` Halil Pasic
2019-01-02 19:13 ` Halil Pasic
2019-01-02 13:56 ` [virtio-dev] " Halil Pasic
2019-01-02 13:56 ` Halil Pasic
2019-01-02 13:56 ` Halil Pasic
2019-01-02 9:53 ` [virtio-dev] " Cornelia Huck
2019-01-03 6:18 ` [virtio-dev] " Wei Wang
2019-01-03 6:18 ` Wei Wang
2019-01-03 6:18 ` Wei Wang
2018-12-28 7:57 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103105916.3f3431c6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.