From: rajur@chelsio.com (Raju Rangoju)
Subject: [PATCH v2] nvmet-rdma: fix null dereference under heavy load
Date: Thu, 3 Jan 2019 22:59:36 +0530 [thread overview]
Message-ID: <20190103172935.GA23880@chelsio.com> (raw)
In-Reply-To: <2874ee1e-a205-44c5-ae91-7ddf039d76f4@mellanox.com>
On Thursday, January 01/03/19, 2019@18:15:55 +0200, Max Gurtovoy wrote:
>
> > spin_unlock_irqrestore(&queue->rsps_lock, flags);
> > if (unlikely(!rsp)) {
> >- rsp = kmalloc(sizeof(*rsp), GFP_KERNEL);
> >+ int ret = -EINVAL;
> >+
>
> no real need to initialize ret variable (sorry I didn't see it in
> first review).
>
>
No problem. I'll post v3.
> >+ rsp = kzalloc(sizeof(*rsp), GFP_KERNEL);
WARNING: multiple messages have this Message-ID (diff)
From: Raju Rangoju <rajur@chelsio.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org,
swise@opengridcomputing.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] nvmet-rdma: fix null dereference under heavy load
Date: Thu, 3 Jan 2019 22:59:36 +0530 [thread overview]
Message-ID: <20190103172935.GA23880@chelsio.com> (raw)
In-Reply-To: <2874ee1e-a205-44c5-ae91-7ddf039d76f4@mellanox.com>
On Thursday, January 01/03/19, 2019 at 18:15:55 +0200, Max Gurtovoy wrote:
>
> > spin_unlock_irqrestore(&queue->rsps_lock, flags);
> > if (unlikely(!rsp)) {
> >- rsp = kmalloc(sizeof(*rsp), GFP_KERNEL);
> >+ int ret = -EINVAL;
> >+
>
> no real need to initialize ret variable (sorry I didn't see it in
> first review).
>
>
No problem. I'll post v3.
> >+ rsp = kzalloc(sizeof(*rsp), GFP_KERNEL);
next prev parent reply other threads:[~2019-01-03 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 10:33 [PATCH v2] nvmet-rdma: fix null dereference under heavy load Raju Rangoju
2019-01-03 10:33 ` Raju Rangoju
2019-01-03 16:15 ` Max Gurtovoy
2019-01-03 16:15 ` Max Gurtovoy
2019-01-03 17:29 ` Raju Rangoju [this message]
2019-01-03 17:29 ` Raju Rangoju
2019-01-03 18:14 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103172935.GA23880@chelsio.com \
--to=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.