All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
Date: Thu, 03 Jan 2019 20:07:56 +0000	[thread overview]
Message-ID: <20190103200755.GD31596@builder> (raw)
In-Reply-To: <16205f0c-3514-731c-e948-38695e3a525d@st.com>

On Thu 03 Jan 02:06 PST 2019, Benjamin GAIGNARD wrote:

> 
> On 1/3/19 8:02 AM, Wei Yongjun wrote:
> > In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check should
> > be replaced with IS_ERR().
> >
> > Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@gmail.com>

Thanks for the fix and the review!

Regards,
Bjorn

> > ---
> >   drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
> > index 34a8e00..4418392 100644
> > --- a/drivers/hwspinlock/stm32_hwspinlock.c
> > +++ b/drivers/hwspinlock/stm32_hwspinlock.c
> > @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
> >   
> >   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >   	io_base = devm_ioremap_resource(&pdev->dev, res);
> > -	if (!io_base)
> > -		return -ENOMEM;
> > +	if (IS_ERR(io_base))
> > +		return PTR_ERR(io_base);
> >   
> >   	array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
> >   	hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
> >
> >
> >

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
Date: Thu, 3 Jan 2019 12:07:55 -0800	[thread overview]
Message-ID: <20190103200755.GD31596@builder> (raw)
In-Reply-To: <16205f0c-3514-731c-e948-38695e3a525d@st.com>

On Thu 03 Jan 02:06 PST 2019, Benjamin GAIGNARD wrote:

> 
> On 1/3/19 8:02 AM, Wei Yongjun wrote:
> > In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check should
> > be replaced with IS_ERR().
> >
> > Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@gmail.com>

Thanks for the fix and the review!

Regards,
Bjorn

> > ---
> >   drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
> > index 34a8e00..4418392 100644
> > --- a/drivers/hwspinlock/stm32_hwspinlock.c
> > +++ b/drivers/hwspinlock/stm32_hwspinlock.c
> > @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
> >   
> >   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >   	io_base = devm_ioremap_resource(&pdev->dev, res);
> > -	if (!io_base)
> > -		return -ENOMEM;
> > +	if (IS_ERR(io_base))
> > +		return PTR_ERR(io_base);
> >   
> >   	array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
> >   	hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
> >
> >
> >

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
Date: Thu, 3 Jan 2019 12:07:56 -0800	[thread overview]
Message-ID: <20190103200755.GD31596@builder> (raw)
In-Reply-To: <16205f0c-3514-731c-e948-38695e3a525d@st.com>

On Thu 03 Jan 02:06 PST 2019, Benjamin GAIGNARD wrote:

> 
> On 1/3/19 8:02 AM, Wei Yongjun wrote:
> > In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check should
> > be replaced with IS_ERR().
> >
> > Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@gmail.com>

Thanks for the fix and the review!

Regards,
Bjorn

> > ---
> >   drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
> > index 34a8e00..4418392 100644
> > --- a/drivers/hwspinlock/stm32_hwspinlock.c
> > +++ b/drivers/hwspinlock/stm32_hwspinlock.c
> > @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
> >   
> >   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >   	io_base = devm_ioremap_resource(&pdev->dev, res);
> > -	if (!io_base)
> > -		return -ENOMEM;
> > +	if (IS_ERR(io_base))
> > +		return PTR_ERR(io_base);
> >   
> >   	array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
> >   	hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
> >
> >
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-03 20:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  6:56 [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe() Wei Yongjun
2019-01-03  7:02 ` Wei Yongjun
2019-01-03  7:02 ` Wei Yongjun
2019-01-03 10:06 ` Benjamin GAIGNARD
2019-01-03 10:06   ` Benjamin GAIGNARD
2019-01-03 10:06   ` Benjamin GAIGNARD
2019-01-03 20:07   ` Bjorn Andersson [this message]
2019-01-03 20:07     ` Bjorn Andersson
2019-01-03 20:07     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103200755.GD31596@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@st.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=ohad@wizery.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.