All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/4] pci/irq: Handle vector reduce and retry
Date: Thu, 3 Jan 2019 14:51:50 -0700	[thread overview]
Message-ID: <20190103215149.GA10822@localhost.localdomain> (raw)
In-Reply-To: <20190103213900.GB168876@google.com>

On Thu, Jan 03, 2019@03:39:01PM -0600, Bjorn Helgaas wrote:
> Hi Keith,
> 
> Thanks a lot for jumping on this.
> 
> I know I'm a broken record.  Please run "git log --oneline
> drivers/pci/msi.c" and make your subject match.

Sure thing, my mistake.
 
> On Thu, Jan 03, 2019@02:09:53PM -0700, Keith Busch wrote:
> Can you also add some explanation to Documentation/PCI/MSI-HOWTO.txt
> about the concept of "sets" and how to use
> nr_sets/sets/recalc_sets/priv?

Yes, will do. Do you prefer documentation in a separate patch or the same
one?

> > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> > index c672f34235e7..326c9bd05f62 100644
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -249,12 +249,16 @@ struct irq_affinity_notify {
> >   *			the MSI(-X) vector space
> >   * @nr_sets:		Length of passed in *sets array
> >   * @sets:		Number of affinitized sets
> > + * @recalc_sets:	Recalculate sets original requested allocation failed
> 
> This sentence is missing something and doesn't parse quite right.
> "if"?  Is "original" superfluous?

Yikes, that was a very poor merge of two different thought streams. I'll
fix that up.

WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, Ming Lei <ming.lei@redhat.com>,
	linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/4] pci/irq: Handle vector reduce and retry
Date: Thu, 3 Jan 2019 14:51:50 -0700	[thread overview]
Message-ID: <20190103215149.GA10822@localhost.localdomain> (raw)
In-Reply-To: <20190103213900.GB168876@google.com>

On Thu, Jan 03, 2019 at 03:39:01PM -0600, Bjorn Helgaas wrote:
> Hi Keith,
> 
> Thanks a lot for jumping on this.
> 
> I know I'm a broken record.  Please run "git log --oneline
> drivers/pci/msi.c" and make your subject match.

Sure thing, my mistake.
 
> On Thu, Jan 03, 2019 at 02:09:53PM -0700, Keith Busch wrote:
> Can you also add some explanation to Documentation/PCI/MSI-HOWTO.txt
> about the concept of "sets" and how to use
> nr_sets/sets/recalc_sets/priv?

Yes, will do. Do you prefer documentation in a separate patch or the same
one?

> > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> > index c672f34235e7..326c9bd05f62 100644
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -249,12 +249,16 @@ struct irq_affinity_notify {
> >   *			the MSI(-X) vector space
> >   * @nr_sets:		Length of passed in *sets array
> >   * @sets:		Number of affinitized sets
> > + * @recalc_sets:	Recalculate sets original requested allocation failed
> 
> This sentence is missing something and doesn't parse quite right.
> "if"?  Is "original" superfluous?

Yikes, that was a very poor merge of two different thought streams. I'll
fix that up.

  reply	other threads:[~2019-01-03 21:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 21:09 [PATCH 1/4] nvme-pci: Set tagset nr_maps just once Keith Busch
2019-01-03 21:09 ` Keith Busch
2019-01-03 21:09 ` [PATCH 2/4] nvme-pci: Distribute io queue types after creation Keith Busch
2019-01-03 21:09   ` Keith Busch
2019-01-03 21:09 ` [PATCH 3/4] pci/irq: Handle vector reduce and retry Keith Busch
2019-01-03 21:09   ` Keith Busch
2019-01-03 21:39   ` Bjorn Helgaas
2019-01-03 21:39     ` Bjorn Helgaas
2019-01-03 21:51     ` Keith Busch [this message]
2019-01-03 21:51       ` Keith Busch
2019-01-03 21:09 ` [PATCH 4/4] nvme-pci: Use PCI to handle IRQ " Keith Busch
2019-01-03 21:09   ` Keith Busch
2019-01-04 18:15 ` [PATCH 1/4] nvme-pci: Set tagset nr_maps just once Christoph Hellwig
2019-01-04 18:15   ` Christoph Hellwig
2019-01-04 18:19   ` Keith Busch
2019-01-04 18:19     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103215149.GA10822@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.