From: Rob Herring <robh@kernel.org>
To: h00249924 <hutenghui@huawei.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, suzhuangluan@hisilicon.com,
kongfei@hisilicon.com, liyuequan@hisilicon.com,
cash.qianli@hisilicon.com, huangli295@hisilicon.com,
hantanglei@huawei.com, wangyoulin1@hisilicon.com,
ninggaoyu@hisilicon.com, hanxiaolong3@hisilicon.com,
Youlin Wang <wwx575822@notesmail.huawei.com>,
Vinod Koul <vkoul@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: [2/3] dmaengine: Extend the k3dma driver binding
Date: Thu, 3 Jan 2019 17:21:44 -0600 [thread overview]
Message-ID: <20190103232144.GA17431@bogus> (raw)
On Fri, Dec 28, 2018 at 02:36:22PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
> See dma.txt first
>
> Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +- "hisilicon,k3-dma-1.0"
> +- "hisilicon,hisi-pcm-asp-dma-1.0"
> - reg: Should contain DMA registers location and length.
> - interrupts: Should contain one interrupt shared by all channel
> - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
Why is a new example needed just for a new compatible string?
> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
> + };
> +
> +Client:
> + i2s2: hisi_i2s {
> + compatible = "hisilicon,hisi-i2s";
> + reg = <0x0 0xe804f800 0x0 0x400>,
> + <0x0 0xe804e000 0x0 0x400>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
> + dmas = <&asp_dmac 18 &asp_dmac 19>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> + };
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: h00249924 <hutenghui@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Youlin Wang <wwx575822@notesmail.huawei.com>,
hanxiaolong3@hisilicon.com, suzhuangluan@hisilicon.com,
hantanglei@huawei.com, linux-kernel@vger.kernel.org,
kongfei@hisilicon.com, ninggaoyu@hisilicon.com,
Vinod Koul <vkoul@kernel.org>,
liyuequan@hisilicon.com, dmaengine@vger.kernel.org,
huangli295@hisilicon.com, wangyoulin1@hisilicon.com,
linux-arm-kernel@lists.infradead.org, cash.qianli@hisilicon.com
Subject: Re: [PATCH 2/3] dmaengine: Extend the k3dma driver binding
Date: Thu, 3 Jan 2019 17:21:44 -0600 [thread overview]
Message-ID: <20190103232144.GA17431@bogus> (raw)
In-Reply-To: <1545978983-124360-2-git-send-email-hutenghui@huawei.com>
On Fri, Dec 28, 2018 at 02:36:22PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
> See dma.txt first
>
> Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +- "hisilicon,k3-dma-1.0"
> +- "hisilicon,hisi-pcm-asp-dma-1.0"
> - reg: Should contain DMA registers location and length.
> - interrupts: Should contain one interrupt shared by all channel
> - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
Why is a new example needed just for a new compatible string?
> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
> + };
> +
> +Client:
> + i2s2: hisi_i2s {
> + compatible = "hisilicon,hisi-i2s";
> + reg = <0x0 0xe804f800 0x0 0x400>,
> + <0x0 0xe804e000 0x0 0x400>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
> + dmas = <&asp_dmac 18 &asp_dmac 19>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> + };
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: h00249924 <hutenghui@huawei.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, suzhuangluan@hisilicon.com,
kongfei@hisilicon.com, liyuequan@hisilicon.com,
cash.qianli@hisilicon.com, huangli295@hisilicon.com,
hantanglei@huawei.com, wangyoulin1@hisilicon.com,
ninggaoyu@hisilicon.com, hanxiaolong3@hisilicon.com,
Youlin Wang <wwx575822@notesmail.huawei.com>,
Vinod Koul <vkoul@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/3] dmaengine: Extend the k3dma driver binding
Date: Thu, 3 Jan 2019 17:21:44 -0600 [thread overview]
Message-ID: <20190103232144.GA17431@bogus> (raw)
In-Reply-To: <1545978983-124360-2-git-send-email-hutenghui@huawei.com>
On Fri, Dec 28, 2018 at 02:36:22PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
> See dma.txt first
>
> Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +- "hisilicon,k3-dma-1.0"
> +- "hisilicon,hisi-pcm-asp-dma-1.0"
> - reg: Should contain DMA registers location and length.
> - interrupts: Should contain one interrupt shared by all channel
> - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
Why is a new example needed just for a new compatible string?
> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
> + };
> +
> +Client:
> + i2s2: hisi_i2s {
> + compatible = "hisilicon,hisi-i2s";
> + reg = <0x0 0xe804f800 0x0 0x400>,
> + <0x0 0xe804e000 0x0 0x400>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
> + dmas = <&asp_dmac 18 &asp_dmac 19>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> + };
> --
> 1.9.1
>
next reply other threads:[~2019-01-03 23:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 23:21 Rob Herring [this message]
2019-01-03 23:21 ` [PATCH 2/3] dmaengine: Extend the k3dma driver binding Rob Herring
2019-01-03 23:21 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 17:32 [1/3] k3dma: Upgrade k3dma drever to support hisi_asp_dma hardware John Stultz
2019-01-04 17:32 ` [PATCH 1/3] " John Stultz
2019-01-04 17:32 ` John Stultz
2019-01-04 17:24 [1/3] " Vinod Koul
2019-01-04 17:24 ` [PATCH 1/3] " Vinod Koul
2019-01-04 17:24 ` Vinod Koul
2019-01-04 2:44 [3/3] arm64: dts: hi3660: Add hisi asp dma device Rob Herring
2019-01-04 2:44 ` [PATCH 3/3] " Rob Herring
2019-01-04 2:44 ` Rob Herring
2019-01-04 2:44 ` Rob Herring
2019-01-02 18:00 [2/3] dmaengine: Extend the k3dma driver binding John Stultz
2019-01-02 18:00 ` [PATCH 2/3] " John Stultz
2019-01-02 18:00 ` John Stultz
2018-12-28 6:36 [3/3] arm64: dts: hi3660: Add hisi asp dma device h00249924
2018-12-28 6:36 ` [PATCH 3/3] " h00249924
2018-12-28 6:36 ` h00249924
2018-12-28 6:36 ` h00249924
2018-12-28 6:36 [2/3] dmaengine: Extend the k3dma driver binding h00249924
2018-12-28 6:36 ` [PATCH 2/3] " h00249924
2018-12-28 6:36 ` h00249924
2018-12-28 6:36 ` h00249924
2018-12-28 6:36 [1/3] k3dma: Upgrade k3dma drever to support hisi_asp_dma hardware h00249924
2018-12-28 6:36 ` [PATCH 1/3] " h00249924
2018-12-28 6:36 ` h00249924
2018-12-28 6:36 ` h00249924
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103232144.GA17431@bogus \
--to=robh@kernel.org \
--cc=cash.qianli@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hantanglei@huawei.com \
--cc=hanxiaolong3@hisilicon.com \
--cc=huangli295@hisilicon.com \
--cc=hutenghui@huawei.com \
--cc=kongfei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuequan@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=ninggaoyu@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=vkoul@kernel.org \
--cc=wangyoulin1@hisilicon.com \
--cc=wwx575822@notesmail.huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.