All of lore.kernel.org
 help / color / mirror / Atom feed
From: LABBE Corentin <clabbe@baylibre.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
Date: Fri, 4 Jan 2019 11:36:26 +0100	[thread overview]
Message-ID: <20190104103626.GA8448@Red> (raw)
In-Reply-To: <20190104103015.GA3738@red-moon>

On Fri, Jan 04, 2019 at 10:30:25AM +0000, Lorenzo Pieralisi wrote:
> On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> > When building on x86, I got the following build failure:
> 
> Hi,
> 
> what tree are you testing on and which config ?

I use the next-20190102 tree
The config can be found at http://kernel.montjoie.ovh/configs/x86

Regards

> 
> Thanks,
> Lorenzo
> 
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> > drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
> >   gpiod_set_value_cansleep(mp->reset_gpio, 0);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~
> >   gpio_set_value_cansleep
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> > drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                    ^~~~~~~~~~~~~~
> >                    devm_gpio_free
> > drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                                                 ^~~~~~~~~~~~~
> >                                                 GPIOF_INIT_LOW
> > 
> > This is due to the missing linux/gpio/consumer.h header
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  drivers/pci/controller/dwc/pci-meson.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> > index 241ebe0c4505..e35e9eaa50ee 100644
> > --- a/drivers/pci/controller/dwc/pci-meson.c
> > +++ b/drivers/pci/controller/dwc/pci-meson.c
> > @@ -8,6 +8,7 @@
> >  
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> > +#include <linux/gpio/consumer.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_gpio.h>
> >  #include <linux/pci.h>
> > -- 
> > 2.19.2
> > 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: bhelgaas@google.com, khilman@baylibre.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
Date: Fri, 4 Jan 2019 11:36:26 +0100	[thread overview]
Message-ID: <20190104103626.GA8448@Red> (raw)
In-Reply-To: <20190104103015.GA3738@red-moon>

On Fri, Jan 04, 2019 at 10:30:25AM +0000, Lorenzo Pieralisi wrote:
> On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> > When building on x86, I got the following build failure:
> 
> Hi,
> 
> what tree are you testing on and which config ?

I use the next-20190102 tree
The config can be found at http://kernel.montjoie.ovh/configs/x86

Regards

> 
> Thanks,
> Lorenzo
> 
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> > drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
> >   gpiod_set_value_cansleep(mp->reset_gpio, 0);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~
> >   gpio_set_value_cansleep
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> > drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                    ^~~~~~~~~~~~~~
> >                    devm_gpio_free
> > drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                                                 ^~~~~~~~~~~~~
> >                                                 GPIOF_INIT_LOW
> > 
> > This is due to the missing linux/gpio/consumer.h header
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  drivers/pci/controller/dwc/pci-meson.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> > index 241ebe0c4505..e35e9eaa50ee 100644
> > --- a/drivers/pci/controller/dwc/pci-meson.c
> > +++ b/drivers/pci/controller/dwc/pci-meson.c
> > @@ -8,6 +8,7 @@
> >  
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> > +#include <linux/gpio/consumer.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_gpio.h>
> >  #include <linux/pci.h>
> > -- 
> > 2.19.2
> > 

WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
Date: Fri, 4 Jan 2019 11:36:26 +0100	[thread overview]
Message-ID: <20190104103626.GA8448@Red> (raw)
In-Reply-To: <20190104103015.GA3738@red-moon>

On Fri, Jan 04, 2019 at 10:30:25AM +0000, Lorenzo Pieralisi wrote:
> On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> > When building on x86, I got the following build failure:
> 
> Hi,
> 
> what tree are you testing on and which config ?

I use the next-20190102 tree
The config can be found at http://kernel.montjoie.ovh/configs/x86

Regards

> 
> Thanks,
> Lorenzo
> 
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> > drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
> >   gpiod_set_value_cansleep(mp->reset_gpio, 0);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~
> >   gpio_set_value_cansleep
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> > drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                    ^~~~~~~~~~~~~~
> >                    devm_gpio_free
> > drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                                                 ^~~~~~~~~~~~~
> >                                                 GPIOF_INIT_LOW
> > 
> > This is due to the missing linux/gpio/consumer.h header
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  drivers/pci/controller/dwc/pci-meson.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> > index 241ebe0c4505..e35e9eaa50ee 100644
> > --- a/drivers/pci/controller/dwc/pci-meson.c
> > +++ b/drivers/pci/controller/dwc/pci-meson.c
> > @@ -8,6 +8,7 @@
> >  
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> > +#include <linux/gpio/consumer.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_gpio.h>
> >  #include <linux/pci.h>
> > -- 
> > 2.19.2
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-04 10:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04  9:08 [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header Corentin Labbe
2019-01-04  9:08 ` Corentin Labbe
2019-01-04  9:08 ` Corentin Labbe
2019-01-04 10:30 ` Lorenzo Pieralisi
2019-01-04 10:30   ` Lorenzo Pieralisi
2019-01-04 10:30   ` Lorenzo Pieralisi
2019-01-04 10:36   ` LABBE Corentin [this message]
2019-01-04 10:36     ` LABBE Corentin
2019-01-04 10:36     ` LABBE Corentin
2019-01-04 11:17     ` Lorenzo Pieralisi
2019-01-04 11:17       ` Lorenzo Pieralisi
2019-01-04 11:17       ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104103626.GA8448@Red \
    --to=clabbe@baylibre.com \
    --cc=bhelgaas@google.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.