From: Russell Parker <russell.parker7@gmail.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org,
evananderson@thelinuxman.us
Subject: Re: [PATCH 1/1] conf/ucm: chtrt5650: Add UCM config for chtrt5650
Date: Fri, 4 Jan 2019 09:30:56 -0800 [thread overview]
Message-ID: <20190104173056.GA9638@celes> (raw)
In-Reply-To: <1f9d849d-db6f-ae8b-5551-efdb1b13bdea@linux.intel.com>
On Wed, Jan 02, 2019 at 10:14:06AM -0600, Pierre-Louis Bossart wrote:
>
> On 12/29/18 11:35 PM, Russell Parker wrote:
> > Add a UCM configuration for the rt5650 codec. Tested on
> > a Samsung Chromebook 3. Adapted with minor modifications
> > from GitHub user evan-a-a's gist:
> > https://gist.github.com/evan-a-a/86b2a698708074530e2d0ee7c6498767
> >
> > Signed-off-by: Russell Parker <russell.parker7@gmail.com>
>
> Interesting, thanks!
>
> IIRC rt5650 is a low-cost version of rt5645, the machine driver only has a
> minor difference in the routing map and the controls are largely identical.
> Could we maybe factor the common codec parts with the include mechanism,
> similar to what was done for the SOC/platform driver settings?
I'll take a stab at parsing out the common configuration this weekend.
Seems like chtrt5645-mono-speaker-analog-mic can also be refactored to
use the shared code.
Any input on naming the shared directory? The existing shared
configurations all seem to be from the same codec. Maybe a
src/conf/ucm/codecs/rt5645-rt5650/ directory is in order.
next prev parent reply other threads:[~2019-01-04 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 5:35 [PATCH 1/1] conf/ucm: chtrt5650: Add UCM config for chtrt5650 Russell Parker
2018-12-30 10:31 ` Jaroslav Kysela
2019-01-02 16:14 ` Pierre-Louis Bossart
2019-01-04 17:30 ` Russell Parker [this message]
2019-01-04 17:39 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104173056.GA9638@celes \
--to=russell.parker7@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=evananderson@thelinuxman.us \
--cc=patch@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.