From: Baoquan He <bhe@redhat.com>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: k-hagio@ab.jp.nec.com, linux-doc@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, bp@alien8.de, anderson@redhat.com,
tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 2/2 v5] kdump, vmcoreinfo: Export the value of sme mask to vmcoreinfo
Date: Mon, 7 Jan 2019 10:29:25 +0800 [thread overview]
Message-ID: <20190107022925.GF30750@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190107014734.9730-3-lijiang@redhat.com>
On 01/07/19 at 09:47am, Lianbo Jiang wrote:
> For AMD machine with SME feature, makedumpfile tools need to know
> whether the crash kernel was encrypted or not. If SME is enabled
^ crashed
> in the first kernel, the crash kernel's page table(pgd/pud/pmd/pte)
^ crashed
> contains the memory encryption mask, so need to remove the sme mask
"makedumpfile needs" or
in makedumpfile need to remove...
> to obtain the true physical address.
>
> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> ---
> arch/x86/kernel/machine_kexec_64.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
> index 4c8acdfdc5a7..bc4108096b18 100644
> --- a/arch/x86/kernel/machine_kexec_64.c
> +++ b/arch/x86/kernel/machine_kexec_64.c
> @@ -352,10 +352,13 @@ void machine_kexec(struct kimage *image)
>
> void arch_crash_save_vmcoreinfo(void)
> {
> + u64 sme_mask = sme_me_mask;
> +
> VMCOREINFO_NUMBER(phys_base);
> VMCOREINFO_SYMBOL(init_top_pgt);
> vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
> pgtable_l5_enabled());
> + VMCOREINFO_NUMBER(sme_mask);
>
> #ifdef CONFIG_NUMA
> VMCOREINFO_SYMBOL(node_data);
> --
> 2.17.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, akpm@linux-foundation.org, dyoung@redhat.com,
linux-doc@vger.kernel.org, k-hagio@ab.jp.nec.com,
anderson@redhat.com
Subject: Re: [PATCH 2/2 v5] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo
Date: Mon, 7 Jan 2019 10:29:25 +0800 [thread overview]
Message-ID: <20190107022925.GF30750@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190107014734.9730-3-lijiang@redhat.com>
On 01/07/19 at 09:47am, Lianbo Jiang wrote:
> For AMD machine with SME feature, makedumpfile tools need to know
> whether the crash kernel was encrypted or not. If SME is enabled
^ crashed
> in the first kernel, the crash kernel's page table(pgd/pud/pmd/pte)
^ crashed
> contains the memory encryption mask, so need to remove the sme mask
"makedumpfile needs" or
in makedumpfile need to remove...
> to obtain the true physical address.
>
> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> ---
> arch/x86/kernel/machine_kexec_64.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
> index 4c8acdfdc5a7..bc4108096b18 100644
> --- a/arch/x86/kernel/machine_kexec_64.c
> +++ b/arch/x86/kernel/machine_kexec_64.c
> @@ -352,10 +352,13 @@ void machine_kexec(struct kimage *image)
>
> void arch_crash_save_vmcoreinfo(void)
> {
> + u64 sme_mask = sme_me_mask;
> +
> VMCOREINFO_NUMBER(phys_base);
> VMCOREINFO_SYMBOL(init_top_pgt);
> vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
> pgtable_l5_enabled());
> + VMCOREINFO_NUMBER(sme_mask);
>
> #ifdef CONFIG_NUMA
> VMCOREINFO_SYMBOL(node_data);
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-01-07 2:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 1:47 [PATCH 0/2 v5] kdump, vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2019-01-07 1:47 ` [PATCH 0/2 v5] kdump,vmcoreinfo: " Lianbo Jiang
2019-01-07 1:47 ` [PATCH 1/2 v5] kdump: add the vmcoreinfo documentation Lianbo Jiang
2019-01-07 1:47 ` Lianbo Jiang
2019-01-07 7:55 ` Hatayama, Daisuke
2019-01-07 7:55 ` Hatayama, Daisuke
2019-01-07 9:38 ` lijiang
2019-01-07 9:38 ` lijiang
2019-01-07 1:47 ` [PATCH 2/2 v5] kdump, vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2019-01-07 1:47 ` [PATCH 2/2 v5] kdump,vmcoreinfo: " Lianbo Jiang
2019-01-07 2:29 ` Baoquan He [this message]
2019-01-07 2:29 ` Baoquan He
2019-01-07 9:42 ` [PATCH 2/2 v5] kdump, vmcoreinfo: " lijiang
2019-01-07 9:42 ` [PATCH 2/2 v5] kdump,vmcoreinfo: " lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107022925.GF30750@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anderson@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.