From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v4] USB: Don't enable LPM if it's already enabled
Date: Mon, 7 Jan 2019 17:16:20 +0100 [thread overview]
Message-ID: <20190107161620.GB2292@kroah.com> (raw)
On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote:
> USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working
> after S3:
> [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
> [ 168.432065] Bluetooth: hci0: Failed to send body at 4 of 1953 (-110)
>
> After some experiments, I found that disabling LPM can workaround the
> issue.
>
> On some platforms, the USB power is cut during S3, so the driver uses
> reset-resume to resume the device. During port resume, LPM gets enabled
> twice, by usb_reset_and_verify_device() and usb_port_resume().
>
> So let's enable LPM for just once, as this solves the issue for the
> device in question.
>
> Also consolidate USB2 LPM functions to usb_enable_usb2_hardware_lpm()
> and usb_disable_usb2_hardware_lpm().
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
What kernel patch does this one "fix"? Adding a "Fixes:" tag would be
good to try to figure out how far back in the kernel releases this
should be backported.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] USB: Don't enable LPM if it's already enabled
Date: Mon, 7 Jan 2019 17:16:20 +0100 [thread overview]
Message-ID: <20190107161620.GB2292@kroah.com> (raw)
In-Reply-To: <20181203102643.22690-1-kai.heng.feng@canonical.com>
On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote:
> USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working
> after S3:
> [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
> [ 168.432065] Bluetooth: hci0: Failed to send body at 4 of 1953 (-110)
>
> After some experiments, I found that disabling LPM can workaround the
> issue.
>
> On some platforms, the USB power is cut during S3, so the driver uses
> reset-resume to resume the device. During port resume, LPM gets enabled
> twice, by usb_reset_and_verify_device() and usb_port_resume().
>
> So let's enable LPM for just once, as this solves the issue for the
> device in question.
>
> Also consolidate USB2 LPM functions to usb_enable_usb2_hardware_lpm()
> and usb_disable_usb2_hardware_lpm().
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
What kernel patch does this one "fix"? Adding a "Fixes:" tag would be
good to try to figure out how far back in the kernel releases this
should be backported.
thanks,
greg k-h
next reply other threads:[~2019-01-07 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 16:16 Greg Kroah-Hartman [this message]
2019-01-07 16:16 ` [PATCH v4] USB: Don't enable LPM if it's already enabled Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-01-11 9:12 [v4] " Greg Kroah-Hartman
2019-01-11 9:12 ` [PATCH v4] " Greg KH
2019-01-08 17:34 [v4] " Alan Stern
2019-01-08 17:34 ` [PATCH v4] " Alan Stern
2019-01-08 16:04 [v4] " Kai-Heng Feng
2019-01-08 16:04 ` [PATCH v4] " Kai Heng Feng
2019-01-08 15:41 [v4] " Greg Kroah-Hartman
2019-01-08 15:41 ` [PATCH v4] " Greg KH
2019-01-08 6:18 [v4] " Kai-Heng Feng
2019-01-08 6:18 ` [PATCH v4] " Kai Heng Feng
2019-01-07 15:05 [v4] " Alan Stern
2019-01-07 15:05 ` [PATCH v4] " Alan Stern
2019-01-07 6:40 [v4] " Kai-Heng Feng
2019-01-07 6:40 ` [PATCH v4] " Kai Heng Feng
2018-12-03 10:26 [v4] " Kai-Heng Feng
2018-12-03 10:26 ` [PATCH v4] " Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107161620.GB2292@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.