All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
	linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: USB: host: ehci: allow tine of highspeed nak-count
Date: Mon, 7 Jan 2019 17:19:06 +0100	[thread overview]
Message-ID: <20190107161906.GC2292@kroah.com> (raw)

On Wed, Nov 14, 2018 at 05:13:15PM +0000, Ben Dooks wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> At least some systems benefit with less scheduling if the NAK count
> value is set higher than the default 4. For instance a Tegra3 with
> an SMSC9512 showed less interrupt load when this was changed to 14.
> 
> To allow the changing of this value, add a sysfs node to each of
> the controllers to allow run-time changing.

That's going to be a pain, why can you not just figure this out at
runtime and adjust it that way?

Also, you can't add a sysfs file and not also add a Documentation/API/
update :(

Can you fix this up to work without needing manual adjustments?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
	linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count
Date: Mon, 7 Jan 2019 17:19:06 +0100	[thread overview]
Message-ID: <20190107161906.GC2292@kroah.com> (raw)
In-Reply-To: <20181114171315.27549-1-ben-linux@fluff.org>

On Wed, Nov 14, 2018 at 05:13:15PM +0000, Ben Dooks wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> At least some systems benefit with less scheduling if the NAK count
> value is set higher than the default 4. For instance a Tegra3 with
> an SMSC9512 showed less interrupt load when this was changed to 14.
> 
> To allow the changing of this value, add a sysfs node to each of
> the controllers to allow run-time changing.

That's going to be a pain, why can you not just figure this out at
runtime and adjust it that way?

Also, you can't add a sysfs file and not also add a Documentation/API/
update :(

Can you fix this up to work without needing manual adjustments?

thanks,

greg k-h

             reply	other threads:[~2019-01-07 16:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 16:19 Greg Kroah-Hartman [this message]
2019-01-07 16:19 ` [PATCH] USB: host: ehci: allow tine of highspeed nak-count Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2018-11-19 10:06 Ben Dooks
2018-11-19 10:06 ` [PATCH] " Ben Dooks
2018-11-16 15:38 Alan Stern
2018-11-16 15:38 ` [PATCH] " Alan Stern
2018-11-16 12:53 Ben Dooks
2018-11-16 12:53 ` [PATCH] " Ben Dooks
2018-11-14 18:47 Alan Stern
2018-11-14 18:47 ` [PATCH] " Alan Stern
2018-11-14 17:13 Ben Dooks
2018-11-14 17:13 ` [PATCH] " Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107161906.GC2292@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben-linux@fluff.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.