From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Li Qiang <liq3ea@163.com>,
"walling@linux.ibm.com" <walling@linux.ibm.com>,
"rth@twiddle.net" <rth@twiddle.net>,
"david@redhat.com" <david@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()
Date: Mon, 7 Jan 2019 17:10:29 +0100 [thread overview]
Message-ID: <20190107171029.35418046.cohuck@redhat.com> (raw)
In-Reply-To: <CAFEAcA8pRzsVbnWDnLqhOeiJ9Ytw--8Cv9qHycr-pYHnaFs_2g@mail.gmail.com>
On Mon, 7 Jan 2019 16:04:35 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
> On Mon, 7 Jan 2019 at 15:57, Cornelia Huck <cohuck@redhat.com> wrote:
> > On Mon, 7 Jan 2019 15:54:21 +0000
> > Peter Maydell <peter.maydell@linaro.org> wrote:
> > > On Mon, 7 Jan 2019 at 15:48, Cornelia Huck <cohuck@redhat.com> wrote:
> > > > Sounds good. But please return anyway in the unplug case, so that the
> > > > code is fine if asserts have been configured out.
> > >
> > > Hopefully that won't cause the compiler to complain about
> > > unreachable code :-)
> >
> > BTW: Is there a common configuration where asserts are configured out?
> > Not that this is an accident waiting to happen...
>
> No -- we insist they are always enabled, and osdep.h will #error
> out if either NDEBUG or G_DISABLE_ASSERT are set.
Ah, now I remember (I thought we still had that problem.)
In that case, no return is needed.
next prev parent reply other threads:[~2019-01-07 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 15:16 [Qemu-devel] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug() Li Qiang
2019-01-04 14:10 ` Cornelia Huck
2019-01-04 14:33 ` [Qemu-devel] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug() Li Qiang
2019-01-07 9:02 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2019-01-07 15:48 ` [Qemu-devel] " Cornelia Huck
2019-01-07 15:54 ` Peter Maydell
2019-01-07 15:57 ` Cornelia Huck
2019-01-07 16:04 ` Peter Maydell
2019-01-07 16:10 ` Cornelia Huck [this message]
2019-01-08 6:42 ` 李强
2019-01-04 15:05 ` [Qemu-devel] [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug() Halil Pasic
2019-01-07 15:45 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107171029.35418046.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=liq3ea@163.com \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.