All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Li Qiang <liq3ea@163.com>, Cornelia Huck <cohuck@redhat.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
	"walling@linux.ibm.com" <walling@linux.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
	"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
	"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>,
	"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()
Date: Mon, 7 Jan 2019 10:02:15 +0100	[thread overview]
Message-ID: <99165260-157a-363e-e0bd-e2d7537ae5dc@redhat.com> (raw)
In-Reply-To: <5C2F6ED2.33D0D1.16460@m12-13.163.com>

On 04.01.19 15:33, Li Qiang wrote:
> What do you think of ‘g_assert_not_reached();’. For example:
> 
>  
> 
> else {
> 
>      g_assert_not_reached();
> 
> }
> 

I agree, if thisever happens, it is a serious programming error, not an
error to report to the user. (after all, he did nothing wrong)

I'd prefer asserts.

-- 

Thanks,

David / dhildenb

  reply	other threads:[~2019-01-07  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 15:16 [Qemu-devel] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug() Li Qiang
2019-01-04 14:10 ` Cornelia Huck
2019-01-04 14:33   ` [Qemu-devel] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug() Li Qiang
2019-01-07  9:02     ` David Hildenbrand [this message]
2019-01-07 15:48     ` [Qemu-devel] " Cornelia Huck
2019-01-07 15:54       ` Peter Maydell
2019-01-07 15:57         ` Cornelia Huck
2019-01-07 16:04           ` Peter Maydell
2019-01-07 16:10             ` Cornelia Huck
2019-01-08  6:42               ` 李强
2019-01-04 15:05   ` [Qemu-devel] [qemu-s390x] [PATCH v2] s390: avoid potential null dereference in s390_pcihost_unplug() Halil Pasic
2019-01-07 15:45     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99165260-157a-363e-e0bd-e2d7537ae5dc@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=liq3ea@163.com \
    --cc=pasic@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.