All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: mpartap-hi6Y0CQ0nG0@public.gmane.org,
	merlijn-tF0PIh4TN3odnm+yROfE0A@public.gmane.org,
	sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	nekit1000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	ofono-bdc2hr5oBkPYtjvyW6yDsg@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Motorola motmdm support
Date: Mon, 7 Jan 2019 18:41:26 +0100	[thread overview]
Message-ID: <20190107174126.GA933@amd> (raw)
In-Reply-To: <20190107152908.GD5544-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1415 bytes --]

Hi!

> > > But that seems to fix a different issue from what you're seeing.
> > 
> > Yes, I can easily work around the problem like this:
> > 
> > It needs huge fixme there, but if you could include it... "always
> > ready" is better than "never ready".
> 
> OK I'll take a look when I get a chance. I think all we need
> to do there is check that cdata->write_offset < cdata->write_buf_sz.

Makes sense. And you probably need to wake up userspace when buffer
was full and free space appears.

> > Have you figured out how the incoming calls are supposed to work? I'm
> > getting this on incoming call:
...
> > ofonod[2534]: Voice: < ~+CIEV=1,4,0\n\r
> > ignoring line
> > ofonod[2534]: Voice: < ~+CLIP="+420xxxxxxxxx",1,1,"",0,"",0\n\r
> > ignoring line

> > I probably could use +CLIP as "there's incoming call", but I don't see
> > anything useful when I hang up and phone should stop ringing. 
> 
> Parsing the number(s) from +CIEV should tell that, see what
> I added to motmdm_read_state().

+CIEV is documented as "indicator event". I can make ofono parse that,
but it will be ... slightly hacky.

Is there "RING" or something like that going on any of the interfaces?

BTW does 5.0-rc1 boot for you?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: ofono@ofono.org
Subject: Re: Motorola motmdm support
Date: Mon, 07 Jan 2019 18:41:26 +0100	[thread overview]
Message-ID: <20190107174126.GA933@amd> (raw)
In-Reply-To: <20190107152908.GD5544@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

Hi!

> > > But that seems to fix a different issue from what you're seeing.
> > 
> > Yes, I can easily work around the problem like this:
> > 
> > It needs huge fixme there, but if you could include it... "always
> > ready" is better than "never ready".
> 
> OK I'll take a look when I get a chance. I think all we need
> to do there is check that cdata->write_offset < cdata->write_buf_sz.

Makes sense. And you probably need to wake up userspace when buffer
was full and free space appears.

> > Have you figured out how the incoming calls are supposed to work? I'm
> > getting this on incoming call:
...
> > ofonod[2534]: Voice: < ~+CIEV=1,4,0\n\r
> > ignoring line
> > ofonod[2534]: Voice: < ~+CLIP="+420xxxxxxxxx",1,1,"",0,"",0\n\r
> > ignoring line

> > I probably could use +CLIP as "there's incoming call", but I don't see
> > anything useful when I hang up and phone should stop ringing. 
> 
> Parsing the number(s) from +CIEV should tell that, see what
> I added to motmdm_read_state().

+CIEV is documented as "indicator event". I can make ofono parse that,
but it will be ... slightly hacky.

Is there "RING" or something like that going on any of the interfaces?

BTW does 5.0-rc1 boot for you?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2019-01-07 17:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29  9:49 Motorola motmdm support Pavel Machek
2018-12-29  9:49 ` Pavel Machek
2018-12-29 21:16 ` Denis Kenzior
2018-12-29 21:16   ` Denis Kenzior
     [not found]   ` <e959006f-5f8d-8d25-b9d2-dbbcb6a5b073-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-29 22:08     ` Pavel Machek
2018-12-29 22:08       ` Pavel Machek
2018-12-30  0:14       ` Denis Kenzior
2018-12-30  0:14         ` Denis Kenzior
     [not found]         ` <20181230181419.GE6707@atomide.com>
     [not found]           ` <20181230181419.GE6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-30 19:13             ` Denis Kenzior
2018-12-30 19:13               ` Denis Kenzior
     [not found]               ` <20181230202454.GF6707@atomide.com>
     [not found]                 ` <20181230202454.GF6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-30 20:46                   ` Denis Kenzior
2018-12-30 20:46                     ` Denis Kenzior
     [not found]                     ` <20181230212253.GG6707@atomide.com>
     [not found]                       ` <20181230212253.GG6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-12-30 22:06                         ` Denis Kenzior
2018-12-30 22:06                           ` Denis Kenzior
     [not found]                           ` <5950f965-effa-25ca-3533-de1b95923aa5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-30 22:33                             ` Pavel Machek
2018-12-30 22:33                               ` Pavel Machek
2018-12-31 21:54                         ` Pavel Machek
2018-12-31 21:54                           ` Pavel Machek
     [not found]                           ` <20181231222329.GI6707@atomide.com>
     [not found]                             ` <20181231222329.GI6707-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2019-01-02 12:15                               ` Pavel Machek
2019-01-02 12:15                                 ` Pavel Machek
     [not found]                                 ` <20190107152908.GD5544@atomide.com>
     [not found]                                   ` <20190107152908.GD5544-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2019-01-07 17:41                                     ` Pavel Machek [this message]
2019-01-07 17:41                                       ` Pavel Machek
2018-12-30 22:39 ` Pavel Machek
2018-12-30 22:39   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107174126.GA933@amd \
    --to=pavel-+zi9xunit7i@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=merlijn-tF0PIh4TN3odnm+yROfE0A@public.gmane.org \
    --cc=mpartap-hi6Y0CQ0nG0@public.gmane.org \
    --cc=nekit1000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ofono-bdc2hr5oBkPYtjvyW6yDsg@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.