From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Ben Dooks <ben@simtec.co.uk>, Kukjin Kim <kgene@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-s3c24xx: Fix boolean expressions in osiris_dvs_notify
Date: Mon, 7 Jan 2019 20:43:24 +0100 [thread overview]
Message-ID: <20190107194324.GC3313@kozik-lap> (raw)
In-Reply-To: <20190103201408.GA27754@embeddedor>
On Thu, Jan 03, 2019 at 02:14:08PM -0600, Gustavo A. R. Silva wrote:
> Fix boolean expressions by using logical AND operator '&&'
> instead of bitwise operator '&'.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++----
Thanks, applied with fixing up -Wparentheses warning. I think you should
update your GCC.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-samsung-soc@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Ben Dooks <ben@simtec.co.uk>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mach-s3c24xx: Fix boolean expressions in osiris_dvs_notify
Date: Mon, 7 Jan 2019 20:43:24 +0100 [thread overview]
Message-ID: <20190107194324.GC3313@kozik-lap> (raw)
In-Reply-To: <20190103201408.GA27754@embeddedor>
On Thu, Jan 03, 2019 at 02:14:08PM -0600, Gustavo A. R. Silva wrote:
> Fix boolean expressions by using logical AND operator '&&'
> instead of bitwise operator '&'.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++----
Thanks, applied with fixing up -Wparentheses warning. I think you should
update your GCC.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-07 19:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 20:14 [PATCH] ARM: mach-s3c24xx: Fix boolean expressions in osiris_dvs_notify Gustavo A. R. Silva
2019-01-03 20:14 ` Gustavo A. R. Silva
2019-01-04 13:27 ` Krzysztof Kozlowski
2019-01-04 13:27 ` Krzysztof Kozlowski
2019-01-07 19:43 ` Krzysztof Kozlowski [this message]
2019-01-07 19:43 ` Krzysztof Kozlowski
2019-01-07 20:32 ` Gustavo A. R. Silva
2019-01-07 20:32 ` Gustavo A. R. Silva
2019-01-08 7:42 ` Krzysztof Kozlowski
2019-01-08 7:42 ` Krzysztof Kozlowski
2019-01-08 18:14 ` Gustavo A. R. Silva
2019-01-08 18:14 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107194324.GC3313@kozik-lap \
--to=krzk@kernel.org \
--cc=ben@simtec.co.uk \
--cc=gustavo@embeddedor.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.