All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	mst@redhat.com, cohuck@redhat.com, borntraeger@de.ibm.com,
	pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com
Subject: Re: [PATCH v4 1/3] virtio-balloon: tweak config_changed implementation
Date: Tue, 08 Jan 2019 00:10:34 -0700	[thread overview]
Message-ID: <20190108071034.GA32048@kroah.com> (raw)
In-Reply-To: <1546923005-40517-2-git-send-email-wei.w.wang@intel.com>

On Tue, Jan 08, 2019 at 12:50:03PM +0800, Wei Wang wrote:
> virtio-ccw has deadlock issues with reading the config space inside the
> interrupt context, so we tweak the virtballoon_changed implementation
> by moving the config read operations into the related workqueue contexts.
> The config_read_bitmap is used as a flag to the workqueue callbacks
> about the related config fields that need to be read.
> 
> The cmd_id_received is also renamed to cmd_id_received_cache, and
> the value should be obtained via virtio_balloon_cmd_id_received.
> 
> Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  drivers/virtio/virtio_balloon.c | 98 +++++++++++++++++++++++++++--------------
>  1 file changed, 65 insertions(+), 33 deletions(-)
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	mst@redhat.com, cohuck@redhat.com, borntraeger@de.ibm.com,
	pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com
Subject: Re: [PATCH v4 1/3] virtio-balloon: tweak config_changed implementation
Date: Tue, 8 Jan 2019 08:10:34 +0100	[thread overview]
Message-ID: <20190108071034.GA32048@kroah.com> (raw)
In-Reply-To: <1546923005-40517-2-git-send-email-wei.w.wang@intel.com>

On Tue, Jan 08, 2019 at 12:50:03PM +0800, Wei Wang wrote:
> virtio-ccw has deadlock issues with reading the config space inside the
> interrupt context, so we tweak the virtballoon_changed implementation
> by moving the config read operations into the related workqueue contexts.
> The config_read_bitmap is used as a flag to the workqueue callbacks
> about the related config fields that need to be read.
> 
> The cmd_id_received is also renamed to cmd_id_received_cache, and
> the value should be obtained via virtio_balloon_cmd_id_received.
> 
> Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  drivers/virtio/virtio_balloon.c | 98 +++++++++++++++++++++++++++--------------
>  1 file changed, 65 insertions(+), 33 deletions(-)
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

  reply	other threads:[~2019-01-08  7:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  4:50 [virtio-dev] [PATCH v4 0/3] virtio-balloon: tweak config_changed Wei Wang
2019-01-08  4:50 ` Wei Wang
2019-01-08  4:50 ` [PATCH v4 1/3] virtio-balloon: tweak config_changed implementation Wei Wang
2019-01-08  4:50 ` [virtio-dev] " Wei Wang
2019-01-08  4:50   ` Wei Wang
2019-01-08  7:10   ` Greg KH [this message]
2019-01-08  7:10     ` Greg KH
2019-01-08  7:10   ` Greg KH
2019-01-08  4:50 ` [virtio-dev] [PATCH v4 2/3] virtio-balloon: improve update_balloon_size_func Wei Wang
2019-01-08  4:50   ` Wei Wang
2019-01-08  7:10   ` Greg KH
2019-01-08  7:10     ` Greg KH
2019-01-08  7:10     ` Greg KH
2019-01-08  4:50 ` Wei Wang
2019-01-08  4:50 ` [PATCH v4 3/3] virtio_balloon: remove the unnecessary 0-initialization Wei Wang
2019-01-08  4:50 ` [virtio-dev] " Wei Wang
2019-01-08  4:50   ` Wei Wang
2019-01-08  7:10   ` Greg KH
2019-01-08  7:10     ` Greg KH
2019-01-08  7:10   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108071034.GA32048@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.