* [PATCH] ALSA: cs46xx: Potential NULL dereference in probe
[not found] <1546895293273.10834@ece.ufl.edu>
@ 2019-01-08 7:43 ` Dan Carpenter
2019-01-08 8:03 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-01-08 7:43 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: security, Vinod Koul, Takashi Iwai, alsa-devel
The "chip->dsp_spos_instance" can be NULL on some of the ealier error
paths in snd_cs46xx_create().
Reported-by: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We don't really consider NULL derefences as security bugs unless they
can be triggered remotely, but it's definitely worth fixing.
sound/pci/cs46xx/dsp_spos.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c
index 598d140bb7cb..5fc497c6d738 100644
--- a/sound/pci/cs46xx/dsp_spos.c
+++ b/sound/pci/cs46xx/dsp_spos.c
@@ -903,6 +903,9 @@ int cs46xx_dsp_proc_done (struct snd_cs46xx *chip)
struct dsp_spos_instance * ins = chip->dsp_spos_instance;
int i;
+ if (!ins)
+ return 0;
+
snd_info_free_entry(ins->proc_sym_info_entry);
ins->proc_sym_info_entry = NULL;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: cs46xx: Potential NULL dereference in probe
2019-01-08 7:43 ` [PATCH] ALSA: cs46xx: Potential NULL dereference in probe Dan Carpenter
@ 2019-01-08 8:03 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-01-08 8:03 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Vinod Koul, alsa-devel, security
On Tue, 08 Jan 2019 08:43:30 +0100,
Dan Carpenter wrote:
>
> The "chip->dsp_spos_instance" can be NULL on some of the ealier error
> paths in snd_cs46xx_create().
>
> Reported-by: "Yavuz, Tuba" <tuba@ece.ufl.edu>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
> ---
> We don't really consider NULL derefences as security bugs unless they
> can be triggered remotely, but it's definitely worth fixing.
Right, I put Cc-to-stable tag as well.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-08 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1546895293273.10834@ece.ufl.edu>
2019-01-08 7:43 ` [PATCH] ALSA: cs46xx: Potential NULL dereference in probe Dan Carpenter
2019-01-08 8:03 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.