All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [RESEND PATCH 09/12] ARM: davinci: remove dead code related to MAC address reading
Date: Tue,  8 Jan 2019 10:15:36 +0100	[thread overview]
Message-ID: <20190108091539.16674-10-brgl@bgdev.pl> (raw)
In-Reply-To: <20190108091539.16674-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

There are no more users of davinci_get_mac_addr(). Remove it.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/common.c | 15 ---------------
 include/linux/davinci_emac.h   |  1 -
 2 files changed, 16 deletions(-)

diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/common.c
index e1d0f0d841ff..0c638fe15dcb 100644
--- a/arch/arm/mach-davinci/common.c
+++ b/arch/arm/mach-davinci/common.c
@@ -26,21 +26,6 @@ EXPORT_SYMBOL(davinci_soc_info);
 void __iomem *davinci_intc_base;
 int davinci_intc_type;
 
-void davinci_get_mac_addr(struct nvmem_device *nvmem, void *context)
-{
-	char *mac_addr = davinci_soc_info.emac_pdata->mac_addr;
-	off_t offset = (off_t)context;
-
-	if (!IS_BUILTIN(CONFIG_NVMEM)) {
-		pr_warn("Cannot read MAC addr from EEPROM without CONFIG_NVMEM\n");
-		return;
-	}
-
-	/* Read MAC addr from EEPROM */
-	if (nvmem_device_read(nvmem, offset, ETH_ALEN, mac_addr) == ETH_ALEN)
-		pr_info("Read MAC addr from EEPROM: %pM\n", mac_addr);
-}
-
 static int __init davinci_init_id(struct davinci_soc_info *soc_info)
 {
 	int			i;
diff --git a/include/linux/davinci_emac.h b/include/linux/davinci_emac.h
index 05b97144d342..28e6cf1356da 100644
--- a/include/linux/davinci_emac.h
+++ b/include/linux/davinci_emac.h
@@ -46,5 +46,4 @@ enum {
 	EMAC_VERSION_2,	/* DM646x */
 };
 
-void davinci_get_mac_addr(struct nvmem_device *nvmem, void *context);
 #endif
-- 
2.19.1

WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: [RESEND PATCH 09/12] ARM: davinci: remove dead code related to MAC address reading
Date: Tue,  8 Jan 2019 10:15:36 +0100	[thread overview]
Message-ID: <20190108091539.16674-10-brgl@bgdev.pl> (raw)
In-Reply-To: <20190108091539.16674-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

There are no more users of davinci_get_mac_addr(). Remove it.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/common.c | 15 ---------------
 include/linux/davinci_emac.h   |  1 -
 2 files changed, 16 deletions(-)

diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/common.c
index e1d0f0d841ff..0c638fe15dcb 100644
--- a/arch/arm/mach-davinci/common.c
+++ b/arch/arm/mach-davinci/common.c
@@ -26,21 +26,6 @@ EXPORT_SYMBOL(davinci_soc_info);
 void __iomem *davinci_intc_base;
 int davinci_intc_type;
 
-void davinci_get_mac_addr(struct nvmem_device *nvmem, void *context)
-{
-	char *mac_addr = davinci_soc_info.emac_pdata->mac_addr;
-	off_t offset = (off_t)context;
-
-	if (!IS_BUILTIN(CONFIG_NVMEM)) {
-		pr_warn("Cannot read MAC addr from EEPROM without CONFIG_NVMEM\n");
-		return;
-	}
-
-	/* Read MAC addr from EEPROM */
-	if (nvmem_device_read(nvmem, offset, ETH_ALEN, mac_addr) == ETH_ALEN)
-		pr_info("Read MAC addr from EEPROM: %pM\n", mac_addr);
-}
-
 static int __init davinci_init_id(struct davinci_soc_info *soc_info)
 {
 	int			i;
diff --git a/include/linux/davinci_emac.h b/include/linux/davinci_emac.h
index 05b97144d342..28e6cf1356da 100644
--- a/include/linux/davinci_emac.h
+++ b/include/linux/davinci_emac.h
@@ -46,5 +46,4 @@ enum {
 	EMAC_VERSION_2,	/* DM646x */
 };
 
-void davinci_get_mac_addr(struct nvmem_device *nvmem, void *context);
 #endif
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-08  9:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  9:15 [RESEND PATCH 00/12] eeprom: at24: remove platform_data Bartosz Golaszewski
2019-01-08  9:15 ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 01/12] ARM: davinci: da850-evm: remove dead MTD code Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 02/12] ARM: davinci: mityomapl138: don't read the MAC address from machine code Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 03/12] ARM: davinci: dm365-evm: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 04/12] ARM: davinci: da830-evm: " Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 05/12] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 06/12] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 07/12] ARM: davinci: sffsdr: fix the at24 eeprom device name Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 08/12] ARM: davinci: sffsdr: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` Bartosz Golaszewski [this message]
2019-01-08  9:15   ` [RESEND PATCH 09/12] ARM: davinci: remove dead code related to MAC address reading Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 10/12] ARM: davinci: mityomapl138: use nvmem notifiers Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 11/12] ARM: davinci: mityomapl138: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-08  9:15 ` [RESEND PATCH 12/12] eeprom: at24: remove at24_platform_data Bartosz Golaszewski
2019-01-08  9:15   ` Bartosz Golaszewski
2019-01-10 14:13 ` [RESEND PATCH 00/12] eeprom: at24: remove platform_data Sekhar Nori
2019-01-10 14:13   ` Sekhar Nori
2019-01-10 14:13   ` Sekhar Nori
2019-01-22 12:22   ` Greg Kroah-Hartman
2019-01-22 12:22     ` Greg Kroah-Hartman
2019-01-27 12:26     ` Bartosz Golaszewski
2019-01-27 12:26       ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108091539.16674-10-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.