All of lore.kernel.org
 help / color / mirror / Atom feed
From: dan.carpenter at oracle.com (Dan Carpenter)
Subject: [bug report] selftests: add seccomp suite
Date: Tue, 8 Jan 2019 23:17:27 +0300	[thread overview]
Message-ID: <20190108201727.GH3253@kadam> (raw)
In-Reply-To: <20180807115718.mqnrnp2aag4tkpqi@kili.mountain>

Hopefully everyone had a happy new year.  :)  This warning is still
present.

regards,
dan carpenter

On Tue, Aug 07, 2018 at 02:57:18PM +0300, Dan Carpenter wrote:
> Hello Kees Cook,
> 
> The patch c99ee51a9d97: "selftests: add seccomp suite" from Jun 16,
> 2015, leads to the following static checker warning:
> 
> 	./tools/testing/selftests/net/tls.c:206 tls_sendmsg_large()
> 	warn: curly braces intended?
> 
> ./tools/testing/selftests/net/tls.c
>    187  TEST_F(tls, sendmsg_large)
>    188  {
>    189          void *mem = malloc(16384);
>    190          size_t send_len = 16384;
>    191          size_t sends = 128;
>    192          struct msghdr msg;
>    193          size_t recvs = 0;
>    194          size_t sent = 0;
>    195  
>    196          memset(&msg, 0, sizeof(struct msghdr));
>    197          while (sent++ < sends) {
>    198                  struct iovec vec = { (void *)mem, send_len };
>    199  
>    200                  msg.msg_iov = &vec;
>    201                  msg.msg_iovlen = 1;
>    202                  EXPECT_EQ(sendmsg(self->cfd, &msg, 0), send_len);
>    203          }
>    204  
>    205          while (recvs++ < sends)
>    206                  EXPECT_NE(recv(self->fd, mem, send_len, 0), -1);
> 
> The EXPECT_NE() macro has an OPTIONAL_HANDLER() which isn't inside the
> do {} while(0).
> 
>    207  
>    208          free(mem);
>    209  }
> 
> regards,
> dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [bug report] selftests: add seccomp suite
Date: Tue, 8 Jan 2019 23:17:27 +0300	[thread overview]
Message-ID: <20190108201727.GH3253@kadam> (raw)
Message-ID: <20190108201727.zfBH2afEQ3cKH7ntxsdiRYhELxiInLtuC7X0MLr5PB8@z> (raw)
In-Reply-To: <20180807115718.mqnrnp2aag4tkpqi@kili.mountain>

Hopefully everyone had a happy new year.  :)  This warning is still
present.

regards,
dan carpenter

On Tue, Aug 07, 2018@02:57:18PM +0300, Dan Carpenter wrote:
> Hello Kees Cook,
> 
> The patch c99ee51a9d97: "selftests: add seccomp suite" from Jun 16,
> 2015, leads to the following static checker warning:
> 
> 	./tools/testing/selftests/net/tls.c:206 tls_sendmsg_large()
> 	warn: curly braces intended?
> 
> ./tools/testing/selftests/net/tls.c
>    187  TEST_F(tls, sendmsg_large)
>    188  {
>    189          void *mem = malloc(16384);
>    190          size_t send_len = 16384;
>    191          size_t sends = 128;
>    192          struct msghdr msg;
>    193          size_t recvs = 0;
>    194          size_t sent = 0;
>    195  
>    196          memset(&msg, 0, sizeof(struct msghdr));
>    197          while (sent++ < sends) {
>    198                  struct iovec vec = { (void *)mem, send_len };
>    199  
>    200                  msg.msg_iov = &vec;
>    201                  msg.msg_iovlen = 1;
>    202                  EXPECT_EQ(sendmsg(self->cfd, &msg, 0), send_len);
>    203          }
>    204  
>    205          while (recvs++ < sends)
>    206                  EXPECT_NE(recv(self->fd, mem, send_len, 0), -1);
> 
> The EXPECT_NE() macro has an OPTIONAL_HANDLER() which isn't inside the
> do {} while(0).
> 
>    207  
>    208          free(mem);
>    209  }
> 
> regards,
> dan carpenter

  reply	other threads:[~2019-01-08 20:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 11:57 [bug report] selftests: add seccomp suite dan.carpenter
2018-08-07 11:57 ` Dan Carpenter
2019-01-08 20:17 ` dan.carpenter [this message]
2019-01-08 20:17   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108201727.GH3253@kadam \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.