From: Jan Kara <jack@suse.cz>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: jack@suse.cz, kvm@vger.kernel.org, linux-nvdimm@ml01.01.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
adilger.kernel@dilger.ca, zwisler@kernel.org, eblake@redhat.com,
dave.jiang@intel.com, darrick.wong@oracle.com,
vishal.l.verma@intel.com, mst@redhat.com, willy@infradead.org,
hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com,
nilal@redhat.com, riel@surriel.com, stefanha@redhat.com,
imammedo@redhat.com, dan.j.williams@intel.com,
lcapitulino@redhat.com, linux-ext4@vger.kernel.org,
tytso@mit.edu, xiaoguangrong.eric@gmail.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 4/5] ext4: disable map_sync for virtio pmem
Date: Wed, 9 Jan 2019 15:42:15 +0100 [thread overview]
Message-ID: <20190109144215.GI15397@quack2.suse.cz> (raw)
In-Reply-To: <20190109135606.15401-1-pagupta@redhat.com>
On Wed 09-01-19 19:26:05, Pankaj Gupta wrote:
> Virtio pmem provides asynchronous host page cache flush
> mechanism. We don't support 'MAP_SYNC' with virtio pmem
> and ext4.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
...
> @@ -371,6 +373,13 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma)
> if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC))
> return -EOPNOTSUPP;
>
> + /* We don't support synchronous mappings with guest direct access
> + * and virtio based host page cache flush mechanism.
> + */
> + if (IS_DAX(file_inode(file)) && virtio_pmem_host_cache_enabled(dax_dev)
> + && (vma->vm_flags & VM_SYNC))
> + return -EOPNOTSUPP;
> +
Shouldn't there rather be some generic way of doing this? Having
virtio_pmem_host_cache_enabled() check in filesystem code just looks like
filesystem sniffing into details is should not care about... Maybe just
naming this (or having a wrapper) dax_dev_map_sync_supported()?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org,
linux-fsdevel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, jack@suse.cz, stefanha@redhat.com,
dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com,
kwolf@redhat.com, pbonzini@redhat.com, zwisler@kernel.org,
vishal.l.verma@intel.com, dave.jiang@intel.com, david@redhat.com,
jmoyer@redhat.com, xiaoguangrong.eric@gmail.com,
hch@infradead.org, mst@redhat.com, jasowang@redhat.com,
lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com,
willy@infradead.org, tytso@mit.edu, adilger.kernel@dilger.ca,
darrick.wong@oracle.com, rjw@rjwysocki.net
Subject: Re: [PATCH v3 4/5] ext4: disable map_sync for virtio pmem
Date: Wed, 9 Jan 2019 15:42:15 +0100 [thread overview]
Message-ID: <20190109144215.GI15397@quack2.suse.cz> (raw)
In-Reply-To: <20190109135606.15401-1-pagupta@redhat.com>
On Wed 09-01-19 19:26:05, Pankaj Gupta wrote:
> Virtio pmem provides asynchronous host page cache flush
> mechanism. We don't support 'MAP_SYNC' with virtio pmem
> and ext4.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
...
> @@ -371,6 +373,13 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma)
> if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC))
> return -EOPNOTSUPP;
>
> + /* We don't support synchronous mappings with guest direct access
> + * and virtio based host page cache flush mechanism.
> + */
> + if (IS_DAX(file_inode(file)) && virtio_pmem_host_cache_enabled(dax_dev)
> + && (vma->vm_flags & VM_SYNC))
> + return -EOPNOTSUPP;
> +
Shouldn't there rather be some generic way of doing this? Having
virtio_pmem_host_cache_enabled() check in filesystem code just looks like
filesystem sniffing into details is should not care about... Maybe just
naming this (or having a wrapper) dax_dev_map_sync_supported()?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-01-09 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 13:56 [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Pankaj Gupta
2019-01-09 13:56 ` Pankaj Gupta
2019-01-09 13:56 ` [PATCH v3 5/5] xfs: " Pankaj Gupta
[not found] ` <20190109135606.15401-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-09 13:56 ` Pankaj Gupta
2019-01-09 13:56 ` Pankaj Gupta
2019-01-09 14:42 ` Jan Kara [this message]
2019-01-09 14:42 ` [PATCH v3 4/5] ext4: " Jan Kara
2019-01-09 14:54 ` Pankaj Gupta
2019-01-09 14:54 ` Pankaj Gupta
2019-01-09 14:54 ` Pankaj Gupta
2019-01-09 14:54 ` Pankaj Gupta
-- strict thread matches above, loose matches on Subject: below --
2019-01-09 13:56 Pankaj Gupta
2019-01-09 14:47 [PATCH v3 0/5] kvm "virtio pmem" device Pankaj Gupta
2019-01-09 14:47 ` [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Pankaj Gupta
2019-01-09 14:47 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109144215.GI15397@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=eblake@redhat.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=stefanha@redhat.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.