From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Andrea Venturi (pers)" <be17068@iperbole.bo.it>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Code Kipper <codekipper@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask
Date: Wed, 9 Jan 2019 18:50:58 +0000 [thread overview]
Message-ID: <20190109185058.GL10405@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v649OVnaYNbZKPtBYkPHkFP13y201RZPTRauNsjiGQKwjw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]
On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote:
> On Fri, Dec 21, 2018 at 11:21 PM <codekipper@gmail.com> wrote:
> > Also add offset to RX channel select
> Commit log seems a bit lacking. You could probably explain how you
> found this, either when comparing datasheet macros, or some actual
> error manifested and you "heard" it. You could also state what the
> fixed outcome should be.
> Also please add a fixes tag.
Plus send this at the start of the series so it can be applied as a fix
and sent to Linus during the development cycle.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Andrea Venturi \(pers\)" <be17068@iperbole.bo.it>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Code Kipper <codekipper@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask
Date: Wed, 9 Jan 2019 18:50:58 +0000 [thread overview]
Message-ID: <20190109185058.GL10405@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v649OVnaYNbZKPtBYkPHkFP13y201RZPTRauNsjiGQKwjw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]
On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote:
> On Fri, Dec 21, 2018 at 11:21 PM <codekipper@gmail.com> wrote:
> > Also add offset to RX channel select
> Commit log seems a bit lacking. You could probably explain how you
> found this, either when comparing datasheet macros, or some actual
> error manifested and you "heard" it. You could also state what the
> fixed outcome should be.
> Also please add a fixes tag.
Plus send this at the start of the series so it can be applied as a fix
and sent to Linus during the development cycle.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Code Kipper <codekipper@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
"Andrea Venturi (pers)" <be17068@iperbole.bo.it>
Subject: Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask
Date: Wed, 9 Jan 2019 18:50:58 +0000 [thread overview]
Message-ID: <20190109185058.GL10405@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v649OVnaYNbZKPtBYkPHkFP13y201RZPTRauNsjiGQKwjw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote:
> On Fri, Dec 21, 2018 at 11:21 PM <codekipper@gmail.com> wrote:
> > Also add offset to RX channel select
> Commit log seems a bit lacking. You could probably explain how you
> found this, either when comparing datasheet macros, or some actual
> error manifested and you "heard" it. You could also state what the
> fixed outcome should be.
> Also please add a fixes tag.
Plus send this at the start of the series so it can be applied as a fix
and sent to Linus during the development cycle.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-09 18:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 15:21 [PATCH v3 0/9] ASoC: sun4i-i2s: Updates to the driver codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
[not found] ` <20181221152110.17982-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-21 15:21 ` [PATCH v3 1/9] ASoC: sun4i-i2s: Adjust regmap settings codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
[not found] ` <20181221152110.17982-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-21 16:44 ` Chen-Yu Tsai
2018-12-21 16:44 ` Chen-Yu Tsai
2018-12-21 16:44 ` Chen-Yu Tsai
2018-12-22 22:12 ` Jonas Karlman
2018-12-22 22:12 ` [alsa-devel] " Jonas Karlman
2018-12-22 22:12 ` Jonas Karlman
[not found] ` <DB7PR03MB46813005FFDFC8609F67F111ACB90-qmxCgCjGUkLCt975IqKlAceAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-12-23 3:16 ` Chen-Yu Tsai
2018-12-23 3:16 ` Chen-Yu Tsai
2018-12-23 3:16 ` Chen-Yu Tsai
2019-01-09 18:49 ` Mark Brown
2019-01-09 18:49 ` [alsa-devel] " Mark Brown
2019-01-09 18:49 ` Mark Brown
2019-01-09 18:46 ` Mark Brown
2019-01-09 18:46 ` Mark Brown
2019-01-09 18:46 ` Mark Brown
2018-12-21 15:21 ` [PATCH v3 2/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
[not found] ` <20181221152110.17982-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-21 17:06 ` Chen-Yu Tsai
2018-12-21 17:06 ` Chen-Yu Tsai
2018-12-21 17:06 ` Chen-Yu Tsai
2018-12-21 15:21 ` [PATCH v3 3/9] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
[not found] ` <20181221152110.17982-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-21 16:48 ` Chen-Yu Tsai
2018-12-21 16:48 ` Chen-Yu Tsai
2018-12-21 16:48 ` Chen-Yu Tsai
[not found] ` <CAGb2v67LyDW6kmDrahzLYsY7q9mSJimrZ=jMO3PrPQ=mcxy0qw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-21 17:15 ` Chen-Yu Tsai
2018-12-21 17:15 ` Chen-Yu Tsai
2018-12-21 17:15 ` Chen-Yu Tsai
2018-12-21 15:21 ` [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
[not found] ` <20181221152110.17982-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-21 16:54 ` Chen-Yu Tsai
2018-12-21 16:54 ` Chen-Yu Tsai
2018-12-21 16:54 ` Chen-Yu Tsai
2019-01-09 18:50 ` Mark Brown [this message]
2019-01-09 18:50 ` Mark Brown
2019-01-09 18:50 ` Mark Brown
2018-12-21 15:21 ` [PATCH v3 5/9] ASoC: sun4i-i2s: Correct divider calculations codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` [PATCH v3 6/9] ASoC: sun4i-i2s: Add multi-lane functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` [PATCH v3 7/9] ASoC: sun4i-i2s: Do not divide clocks when slave codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` [PATCH v3 8/9] ASoC: sun4i-i2s: Add set_tdm_slot functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` [PATCH v3 9/9] ASoC: sun4i-i2s: Add multichannel functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-12-21 15:21 ` codekipper
2018-12-21 15:21 ` codekipper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109185058.GL10405@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.