* [PATCH] nvme-cli: Fixup compilation with user-defined CFLAGS
@ 2019-01-10 8:10 Hannes Reinecke
2019-01-10 8:11 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2019-01-10 8:10 UTC (permalink / raw)
Calling 'make CFLAGS="-Wall"' breaks compilation as the include
statement will be overwritten.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 525616a..4ea19dd 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
-CFLAGS ?= -O2 -g -Wall -Werror -I.
-CFLAGS += -std=gnu99
+CFLAGS ?= -O2 -g -Wall -Werror
+CFLAGS += -I. -std=gnu99
CPPFLAGS += -D_GNU_SOURCE -D__CHECK_ENDIAN__
LIBUUID = $(shell $(LD) -o /dev/null -luuid >/dev/null 2>&1; echo $$?)
NVME = nvme
--
2.13.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-cli: Fixup compilation with user-defined CFLAGS
2019-01-10 8:10 [PATCH] nvme-cli: Fixup compilation with user-defined CFLAGS Hannes Reinecke
@ 2019-01-10 8:11 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2019-01-10 8:11 UTC (permalink / raw)
On 1/10/19 9:10 AM, Hannes Reinecke wrote:
> Calling 'make CFLAGS="-Wall"' breaks compilation as the include
> statement will be overwritten.
>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 525616a..4ea19dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,5 +1,5 @@
> -CFLAGS ?= -O2 -g -Wall -Werror -I.
> -CFLAGS += -std=gnu99
> +CFLAGS ?= -O2 -g -Wall -Werror
> +CFLAGS += -I. -std=gnu99
> CPPFLAGS += -D_GNU_SOURCE -D__CHECK_ENDIAN__
> LIBUUID = $(shell $(LD) -o /dev/null -luuid >/dev/null 2>&1; echo $$?)
> NVME = nvme
>
Please disregard. This patch doesn't fix it :-(
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-10 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-10 8:10 [PATCH] nvme-cli: Fixup compilation with user-defined CFLAGS Hannes Reinecke
2019-01-10 8:11 ` Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.