From: Thierry Reding <thierry.reding@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state()
Date: Thu, 10 Jan 2019 11:08:22 +0000 [thread overview]
Message-ID: <20190110110822.GA17719@ulmo> (raw)
In-Reply-To: <20190109082747.GA5476@kadam>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Thu, Jan 10, 2019 at 11:18:18AM +0100, Uwe Kleine-König wrote:
> On Wed, Jan 09, 2019 at 11:27:47AM +0300, Dan Carpenter wrote:
> > "ret" only holds zero and negative error codes. It needs to be signed
> > for the error handling to work.
> >
> > Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I would have expected a compiler warning but at least for me there is
> none emitted. Hmm.
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> @Thierry: Given that this is a fix I assume you want to apply this patch
> before my pwm-imx series (which is cleanup only). This will conflict for
> sure with my driver splitting patch. Please tell me if/when I should
> resend my series rebased on top of this patch.
It's fine, I manually applied this on top of the driver split patch.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Anson Huang <anson.huang@nxp.com>,
linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state()
Date: Thu, 10 Jan 2019 12:08:22 +0100 [thread overview]
Message-ID: <20190110110822.GA17719@ulmo> (raw)
In-Reply-To: <20190110101818.msnvtpw6yczpeybc@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Thu, Jan 10, 2019 at 11:18:18AM +0100, Uwe Kleine-König wrote:
> On Wed, Jan 09, 2019 at 11:27:47AM +0300, Dan Carpenter wrote:
> > "ret" only holds zero and negative error codes. It needs to be signed
> > for the error handling to work.
> >
> > Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I would have expected a compiler warning but at least for me there is
> none emitted. Hmm.
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> @Thierry: Given that this is a fix I assume you want to apply this patch
> before my pwm-imx series (which is cleanup only). This will conflict for
> sure with my driver splitting patch. Please tell me if/when I should
> resend my series rebased on top of this patch.
It's fine, I manually applied this on top of the driver split patch.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-10 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:27 [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state() Dan Carpenter
2019-01-09 8:27 ` Dan Carpenter
2019-01-10 10:18 ` Uwe Kleine-König
2019-01-10 10:18 ` Uwe Kleine-König
2019-01-10 11:08 ` Thierry Reding [this message]
2019-01-10 11:08 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110110822.GA17719@ulmo \
--to=thierry.reding@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.