From: Kyle Williams <kdgwill@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Jon Flatley <jflat@chromium.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-usb@vger.kernel.org
Subject: [v3,1/2] USB: quirks: Check device interface LPM capability
Date: Thu, 10 Jan 2019 10:49:09 -0500 [thread overview]
Message-ID: <20190110154909.GB142026@google.com> (raw)
On Wed, Dec 12, 2018 at 12:37:09PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote:
> > From: Kyle Williams <kdgwill@chromium.org>
> >
> > Description: enable the ability to disable LPM for all devices matched
> > by interface information
>
> Why have "Description:" in here? Of course this is the description :)
>
> And the subject doesn't make much sense, what does this have to do with
> quirks?
>
> Also, you need more information here in the description about why you
> are doing all of this, as it is, I have no idea why this patch is needed
> at all.
>
> thanks,
>
> greg k-h
It seems the underlying issue has been solved in
0472bf0 xhci: Prevent U1/U2 link pm states if exit latency is too long
However, the patch to fix the issue when matching the USB_QUIRK_NO_LPM
quirk by iterface could be useful in the future. Currently nothing will
happen that quirk is matched by interface instead of by vid/pid pair.
Is their anything that would need to be changed besides removing the
Description tag?
-Kyle
WARNING: multiple messages have this Message-ID (diff)
From: Kyle Williams <kdgwill@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Jon Flatley <jflat@chromium.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] USB: quirks: Check device interface LPM capability
Date: Thu, 10 Jan 2019 10:49:09 -0500 [thread overview]
Message-ID: <20190110154909.GB142026@google.com> (raw)
In-Reply-To: <20181212113709.GA20058@kroah.com>
On Wed, Dec 12, 2018 at 12:37:09PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote:
> > From: Kyle Williams <kdgwill@chromium.org>
> >
> > Description: enable the ability to disable LPM for all devices matched
> > by interface information
>
> Why have "Description:" in here? Of course this is the description :)
>
> And the subject doesn't make much sense, what does this have to do with
> quirks?
>
> Also, you need more information here in the description about why you
> are doing all of this, as it is, I have no idea why this patch is needed
> at all.
>
> thanks,
>
> greg k-h
It seems the underlying issue has been solved in
0472bf0 xhci: Prevent U1/U2 link pm states if exit latency is too long
However, the patch to fix the issue when matching the USB_QUIRK_NO_LPM
quirk by iterface could be useful in the future. Currently nothing will
happen that quirk is matched by interface instead of by vid/pid pair.
Is their anything that would need to be changed besides removing the
Description tag?
-Kyle
next reply other threads:[~2019-01-10 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 15:49 Kyle Williams [this message]
2019-01-10 15:49 ` [PATCH v3 1/2] USB: quirks: Check device interface LPM capability Kyle Williams
-- strict thread matches above, loose matches on Subject: below --
2019-01-11 9:09 [v3,1/2] " Greg Kroah-Hartman
2019-01-11 9:09 ` [PATCH v3 1/2] " Greg Kroah-Hartman
2018-12-12 11:37 [v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices Greg Kroah-Hartman
2018-12-12 11:37 ` [PATCH v3 2/2] " Greg Kroah-Hartman
2018-12-12 11:37 [v3,1/2] USB: quirks: Check device interface LPM capability Greg Kroah-Hartman
2018-12-12 11:37 ` [PATCH v3 1/2] " Greg Kroah-Hartman
2018-12-08 1:47 [v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices Kyle Williams
2018-12-08 1:47 ` [PATCH v3 2/2] " Kyle Williams
2018-12-08 1:47 [v3,1/2] USB: quirks: Check device interface LPM capability Kyle Williams
2018-12-08 1:47 ` [PATCH v3 1/2] " Kyle Williams
2018-12-08 0:46 [v2] USB: quirks: disable LPM for Logitech UVC devices Kyle Williams
2018-12-08 0:46 ` [PATCH v2] " Kyle Williams
[not found] <CAAd214WBzcsFamzqkdTp0AYDRo1=Uq1=Z5fJhzkOZ6znVFo3MA@mail.gmail.com>
2018-12-04 21:36 ` [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally Alan Stern
2018-12-07 22:18 ` Kyle Williams
2018-12-10 13:50 ` Mathias Nyman
2019-01-10 14:36 ` Kyle Williams
2018-12-05 9:39 ` Greg Kroah-Hartman
2018-12-07 22:21 ` Kyle Williams
2018-12-08 1:47 ` [PATCH v3 0/2] Disable LPM by matching interface Kyle Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110154909.GB142026@google.com \
--to=kdgwill@chromium.org \
--cc=drinkcat@chromium.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jflat@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.