All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <bbrezillon@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated
Date: Thu, 10 Jan 2019 18:48:25 +0100	[thread overview]
Message-ID: <20190110184816.63350396@bbrezillon> (raw)
In-Reply-To: <20190110151020.30468-3-peda@axentia.se>

On Thu, 10 Jan 2019 15:10:39 +0000
Peter Rosin <peda@axentia.se> wrote:

> The destination crtc rectangle is independent of source plane rotation.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index ea8fc0deb814..d6f93f029020 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -642,9 +642,6 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
>  	 * Swap width and size in case of 90 or 270 degrees rotation
>  	 */
>  	if (drm_rotation_90_or_270(state->base.rotation)) {
> -		tmp = state->crtc_w;
> -		state->crtc_w = state->crtc_h;
> -		state->crtc_h = tmp;

Again, I guess I assumed ->crtc_h/w were the width and height before
rotation when I initially added rotation support. This change might
break users too.

>  		tmp = state->src_w;
>  		state->src_w = state->src_h;
>  		state->src_h = tmp;


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated
Date: Thu, 10 Jan 2019 18:48:25 +0100	[thread overview]
Message-ID: <20190110184816.63350396@bbrezillon> (raw)
In-Reply-To: <20190110151020.30468-3-peda@axentia.se>

On Thu, 10 Jan 2019 15:10:39 +0000
Peter Rosin <peda@axentia.se> wrote:

> The destination crtc rectangle is independent of source plane rotation.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index ea8fc0deb814..d6f93f029020 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -642,9 +642,6 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
>  	 * Swap width and size in case of 90 or 270 degrees rotation
>  	 */
>  	if (drm_rotation_90_or_270(state->base.rotation)) {
> -		tmp = state->crtc_w;
> -		state->crtc_w = state->crtc_h;
> -		state->crtc_h = tmp;

Again, I guess I assumed ->crtc_h/w were the width and height before
rotation when I initially added rotation support. This change might
break users too.

>  		tmp = state->src_w;
>  		state->src_w = state->src_h;
>  		state->src_h = tmp;

  reply	other threads:[~2019-01-10 17:48 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 15:10 [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Peter Rosin
2019-01-10 15:10 ` Peter Rosin
2019-01-10 15:10 ` [PATCH 1/4] drm/atmel-hlcdc: rotate planes counterclockwise Peter Rosin
2019-01-10 15:10   ` Peter Rosin
2019-01-10 15:10 ` [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated Peter Rosin
2019-01-10 15:10   ` Peter Rosin
2019-01-10 17:48   ` Boris Brezillon [this message]
2019-01-10 17:48     ` Boris Brezillon
2019-01-11 13:29     ` Peter Rosin
2019-01-11 13:29       ` Peter Rosin
2019-01-11 13:29       ` Peter Rosin
2019-01-11 14:14       ` Nicolas.Ferre
2019-01-11 14:14         ` Nicolas.Ferre
2019-01-11 14:14         ` Nicolas.Ferre
2019-01-10 15:10 ` [PATCH 3/4] drm/atmel-hlcdc: fix clipping of planes Peter Rosin
2019-01-10 15:10   ` Peter Rosin
2019-01-10 15:10 ` [PATCH 4/4] drm/atmel-hlcdc: do not immediately disable planes, wait for next frame Peter Rosin
2019-01-10 15:10   ` Peter Rosin
2019-01-10 17:29   ` Boris Brezillon
2019-01-10 17:29     ` Boris Brezillon
2019-01-10 17:29     ` Boris Brezillon
2019-01-10 18:51     ` Peter Rosin
2019-01-10 18:51       ` Peter Rosin
2019-01-10 18:51       ` Peter Rosin
2019-01-10 19:25       ` Boris Brezillon
2019-01-10 19:25         ` Boris Brezillon
2019-01-10 19:25         ` Boris Brezillon
2019-01-11 14:29         ` Peter Rosin
2019-01-11 14:29           ` Peter Rosin
2019-01-11 14:29           ` Peter Rosin
2019-01-16 14:45           ` Boris Brezillon
2019-01-16 14:45             ` Boris Brezillon
2019-01-16 14:45             ` Boris Brezillon
2019-01-10 17:45 ` [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Boris Brezillon
2019-01-10 17:45   ` Boris Brezillon
2019-01-10 17:45   ` Boris Brezillon
2019-01-10 20:16   ` Sam Ravnborg
2019-01-10 20:16     ` Sam Ravnborg
2019-01-10 20:16     ` Sam Ravnborg
2019-01-11  9:16     ` Peter Rosin
2019-01-11  9:16       ` Peter Rosin
2019-01-11  9:16       ` Peter Rosin
2019-01-10 21:24   ` Peter Rosin
2019-01-10 21:24     ` Peter Rosin
2019-01-11 14:18   ` Nicolas.Ferre
2019-01-11 14:18     ` Nicolas.Ferre
2019-01-11 14:18     ` Nicolas.Ferre
2019-01-27  8:27 ` Boris Brezillon
2019-01-27  8:27   ` Boris Brezillon
2019-01-27  8:27   ` Boris Brezillon
2019-01-31 13:13   ` Peter Rosin
2019-01-31 13:13     ` Peter Rosin
2019-01-31 13:21     ` Boris Brezillon
2019-01-31 13:21       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110184816.63350396@bbrezillon \
    --to=bbrezillon@kernel.org \
    --cc=airlied@linux.ie \
    --cc=alexandre.belloni@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.