From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: [PATCH 10/11] crypto: af_alg - use list_for_each_entry() in af_alg_count_tsgl()
Date: Thu, 10 Jan 2019 12:18:01 -0800 [thread overview]
Message-ID: <20190110201802.82442-11-ebiggers@kernel.org> (raw)
In-Reply-To: <20190110201802.82442-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
af_alg_count_tsgl() iterates through a list without modifying it, so use
list_for_each_entry() rather than list_for_each_entry_safe(). Also make
the pointers 'const' to make it clearer that nothing is modified.
No actual change in behavior.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/af_alg.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index ccae4a7ada8ab..1dd573a441279 100644
--- a/crypto/af_alg.c
+++ b/crypto/af_alg.c
@@ -530,17 +530,17 @@ static int af_alg_alloc_tsgl(struct sock *sk)
*/
unsigned int af_alg_count_tsgl(struct sock *sk, size_t bytes, size_t offset)
{
- struct alg_sock *ask = alg_sk(sk);
- struct af_alg_ctx *ctx = ask->private;
- struct af_alg_tsgl *sgl, *tmp;
+ const struct alg_sock *ask = alg_sk(sk);
+ const struct af_alg_ctx *ctx = ask->private;
+ const struct af_alg_tsgl *sgl;
unsigned int i;
unsigned int sgl_count = 0;
if (!bytes)
return 0;
- list_for_each_entry_safe(sgl, tmp, &ctx->tsgl_list, list) {
- struct scatterlist *sg = sgl->sg;
+ list_for_each_entry(sgl, &ctx->tsgl_list, list) {
+ const struct scatterlist *sg = sgl->sg;
for (i = 0; i < sgl->cur; i++) {
size_t bytes_count;
--
2.20.1.97.g81188d93c3-goog
next prev parent reply other threads:[~2019-01-10 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:17 [PATCH 00/11] crypto: misc fixes/cleanups Eric Biggers
2019-01-10 20:17 ` [PATCH 01/11] crypto: gcm - use correct endianness type in gcm_hash_len() Eric Biggers
2019-01-10 20:17 ` [PATCH 02/11] crypto: rsa-pkcs1pad - include <crypto/internal/rsa.h> Eric Biggers
2019-01-10 20:17 ` [PATCH 03/11] crypto: streebog - use correct endianness type Eric Biggers
2019-01-10 20:17 ` [PATCH 04/11] crypto: testmgr - handle endianness correctly in alg_test_crc32c() Eric Biggers
2019-01-10 20:17 ` [PATCH 05/11] crypto: user - forward declare crypto_nlsk Eric Biggers
2019-01-10 20:17 ` [PATCH 06/11] crypto: x86/aesni-gcm - make 'struct aesni_gcm_tfm_s' static const Eric Biggers
2019-01-10 20:17 ` [PATCH 07/11] crypto: tgr192 - fix unaligned memory access Eric Biggers
2019-01-10 20:17 ` [PATCH 08/11] crypto: stat - remove unused mutex Eric Biggers
2019-01-10 20:18 ` [PATCH 09/11] crypto: af_alg - make some functions static Eric Biggers
2019-01-10 20:18 ` Eric Biggers [this message]
2019-01-10 20:18 ` [PATCH 11/11] crypto: af_alg - remove redundant initializations of sk_family Eric Biggers
2019-01-18 10:57 ` [PATCH 00/11] crypto: misc fixes/cleanups Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110201802.82442-11-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.