All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: Corentin Labbe <clabbe@baylibre.com>
Subject: [PATCH 05/11] crypto: user - forward declare crypto_nlsk
Date: Thu, 10 Jan 2019 12:17:56 -0800	[thread overview]
Message-ID: <20190110201802.82442-6-ebiggers@kernel.org> (raw)
In-Reply-To: <20190110201802.82442-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

Move the declaration of crypto_nlsk into internal/cryptouser.h.  This
fixes the following sparse warning:

    crypto/crypto_user_base.c:41:13: warning: symbol 'crypto_nlsk' was not declared. Should it be static?

Cc: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/crypto_user_stat.c            | 2 --
 include/crypto/internal/cryptouser.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index 3e9a53233d804..d4d1cb2bedd7f 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -22,8 +22,6 @@
 
 static DEFINE_MUTEX(crypto_cfg_mutex);
 
-extern struct sock *crypto_nlsk;
-
 struct crypto_dump_info {
 	struct sk_buff *in_skb;
 	struct sk_buff *out_skb;
diff --git a/include/crypto/internal/cryptouser.h b/include/crypto/internal/cryptouser.h
index 40623f4457df6..8c602b187c58a 100644
--- a/include/crypto/internal/cryptouser.h
+++ b/include/crypto/internal/cryptouser.h
@@ -1,6 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #include <net/netlink.h>
 
+extern struct sock *crypto_nlsk;
+
 struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact);
 
 #ifdef CONFIG_CRYPTO_STATS
-- 
2.20.1.97.g81188d93c3-goog

  parent reply	other threads:[~2019-01-10 20:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 20:17 [PATCH 00/11] crypto: misc fixes/cleanups Eric Biggers
2019-01-10 20:17 ` [PATCH 01/11] crypto: gcm - use correct endianness type in gcm_hash_len() Eric Biggers
2019-01-10 20:17 ` [PATCH 02/11] crypto: rsa-pkcs1pad - include <crypto/internal/rsa.h> Eric Biggers
2019-01-10 20:17 ` [PATCH 03/11] crypto: streebog - use correct endianness type Eric Biggers
2019-01-10 20:17 ` [PATCH 04/11] crypto: testmgr - handle endianness correctly in alg_test_crc32c() Eric Biggers
2019-01-10 20:17 ` Eric Biggers [this message]
2019-01-10 20:17 ` [PATCH 06/11] crypto: x86/aesni-gcm - make 'struct aesni_gcm_tfm_s' static const Eric Biggers
2019-01-10 20:17 ` [PATCH 07/11] crypto: tgr192 - fix unaligned memory access Eric Biggers
2019-01-10 20:17 ` [PATCH 08/11] crypto: stat - remove unused mutex Eric Biggers
2019-01-10 20:18 ` [PATCH 09/11] crypto: af_alg - make some functions static Eric Biggers
2019-01-10 20:18 ` [PATCH 10/11] crypto: af_alg - use list_for_each_entry() in af_alg_count_tsgl() Eric Biggers
2019-01-10 20:18 ` [PATCH 11/11] crypto: af_alg - remove redundant initializations of sk_family Eric Biggers
2019-01-18 10:57 ` [PATCH 00/11] crypto: misc fixes/cleanups Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110201802.82442-6-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=clabbe@baylibre.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.