From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Cc: stern@rowland.harvard.edu, jrdr.linux@gmail.com,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, brajeswar.linux@gmail.com
Subject: drivers/usb/storage/sddr55.c: Remove duplicate header
Date: Fri, 11 Jan 2019 10:10:37 +0100 [thread overview]
Message-ID: <20190111091037.GB15610@kroah.com> (raw)
On Thu, Jan 10, 2019 at 01:10:25PM +0530, Sabyasachi Gupta wrote:
> Remove unusual_sddr55.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/usb/storage/sddr55.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index b8527c5..96bf7ee 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids);
> }
>
> static struct us_unusual_dev sddr55_unusual_dev_list[] = {
> -# include "unusual_sddr55.h"
> { } /* Terminating entry */
> };
As Oliver said on the other patch, this breaks the code. Please do not
blindly make changes without understanding what the code does.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Cc: stern@rowland.harvard.edu, jrdr.linux@gmail.com,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, brajeswar.linux@gmail.com
Subject: Re: [PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header
Date: Fri, 11 Jan 2019 10:10:37 +0100 [thread overview]
Message-ID: <20190111091037.GB15610@kroah.com> (raw)
In-Reply-To: <5c36f6ef.1c69fb81.9d82d.5592@mx.google.com>
On Thu, Jan 10, 2019 at 01:10:25PM +0530, Sabyasachi Gupta wrote:
> Remove unusual_sddr55.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/usb/storage/sddr55.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index b8527c5..96bf7ee 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids);
> }
>
> static struct us_unusual_dev sddr55_unusual_dev_list[] = {
> -# include "unusual_sddr55.h"
> { } /* Terminating entry */
> };
As Oliver said on the other patch, this breaks the code. Please do not
blindly make changes without understanding what the code does.
thanks,
greg k-h
next reply other threads:[~2019-01-11 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:10 Greg Kroah-Hartman [this message]
2019-01-11 9:10 ` [PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-01-11 10:59 Oliver Neukum
2019-01-11 10:59 ` [PATCH] " Oliver Neukum
2019-01-10 7:40 Sabyasachi Gupta
2019-01-10 7:40 ` [PATCH] " Sabyasachi Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111091037.GB15610@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brajeswar.linux@gmail.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.