All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Vid <vladimir.vid@sartura.hr>
Cc: devicetree@vger.kernel.org, Luka Perkov <luka.perkov@sartura.hr>,
	Paul Arola <paul.arola@telus.com>,
	Luis Torres <luis.torres@methode.com>,
	Scott Roberts <scott.roberts@telus.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: marvell: Add device tree for uDPU board
Date: Fri, 11 Jan 2019 18:41:47 +0100	[thread overview]
Message-ID: <20190111174147.GG20924@lunn.ch> (raw)
In-Reply-To: <20190111172055.30451-1-vladimir.vid@sartura.hr>

> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> new file mode 100644
> index 000000000000..eae30322a037
> --- /dev/null
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device tree for the uDPU board.
> + * Based on Marvell Armada 3720 development board (DB-88F3720-DDR3)
> + * Copyright (C) 2016 Marvell
> + * Copyright (C) 2018 Methode
> + * Copyright (C) 2018 Telus
> + *
> + * Vladimir Vid <vladimir.vid@sartura.hr>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "armada-372x.dtsi"
> +
> +/ {
> +	model = "Methode uDPU Board";
> +	compatible = "marvell,armada-3720-db", "marvell,armada3720",
> +		     "marvell,armada3710";
> +

Hi Vladimir

There should be a compatible string here for the board. It looks like
you will also need to add Methode as a vendor to
Documentation/devicetree/bindings/vendor-prefixes.txt.

> +	leds {
> +		pinctrl-names = "default";
> +		compatible = "gpio-leds";
> +
> +		led@487 {
> +			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
> +			default-state = "off";

It is normal to have a name here, indicating what the LED is for, its
colour, etc.

> +&mdio {
> +	status = "okay";
> +	phy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
> +	phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};
> +};

These don't appear to be used anywhere. 

      Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Vid <vladimir.vid@sartura.hr>
Cc: devicetree@vger.kernel.org, Luka Perkov <luka.perkov@sartura.hr>,
	Paul Arola <paul.arola@telus.com>,
	Luis Torres <luis.torres@methode.com>,
	Scott Roberts <scott.roberts@telus.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: marvell: Add device tree for uDPU board
Date: Fri, 11 Jan 2019 18:41:47 +0100	[thread overview]
Message-ID: <20190111174147.GG20924@lunn.ch> (raw)
In-Reply-To: <20190111172055.30451-1-vladimir.vid@sartura.hr>

> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> new file mode 100644
> index 000000000000..eae30322a037
> --- /dev/null
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device tree for the uDPU board.
> + * Based on Marvell Armada 3720 development board (DB-88F3720-DDR3)
> + * Copyright (C) 2016 Marvell
> + * Copyright (C) 2018 Methode
> + * Copyright (C) 2018 Telus
> + *
> + * Vladimir Vid <vladimir.vid@sartura.hr>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "armada-372x.dtsi"
> +
> +/ {
> +	model = "Methode uDPU Board";
> +	compatible = "marvell,armada-3720-db", "marvell,armada3720",
> +		     "marvell,armada3710";
> +

Hi Vladimir

There should be a compatible string here for the board. It looks like
you will also need to add Methode as a vendor to
Documentation/devicetree/bindings/vendor-prefixes.txt.

> +	leds {
> +		pinctrl-names = "default";
> +		compatible = "gpio-leds";
> +
> +		led@487 {
> +			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
> +			default-state = "off";

It is normal to have a name here, indicating what the LED is for, its
colour, etc.

> +&mdio {
> +	status = "okay";
> +	phy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
> +	phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};
> +};

These don't appear to be used anywhere. 

      Andrew

  reply	other threads:[~2019-01-11 17:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 17:20 [PATCH] arm64: dts: marvell: Add device tree for uDPU board Vladimir Vid
2019-01-11 17:20 ` Vladimir Vid
2019-01-11 17:41 ` Andrew Lunn [this message]
2019-01-11 17:41   ` Andrew Lunn
2019-01-11 17:44 ` Andrew Lunn
2019-01-11 17:44   ` Andrew Lunn
2019-01-15 12:11 ` [PATCH v2 1/2] " Vladimir Vid
2019-01-15 12:11   ` Vladimir Vid
2019-01-15 13:42   ` Andrew Lunn
2019-01-15 13:42     ` Andrew Lunn
2019-01-15 12:11 ` [PATCH v2 2/2] dt-bindings: add Methode Electronics vendor prefix Vladimir Vid
2019-01-15 13:45   ` Andrew Lunn
2019-01-16 21:39   ` Rob Herring
2019-01-15 14:44 ` [PATCH v3] arm64: dts: marvell: Add device tree for uDPU board Vladimir Vid
2019-01-15 14:44   ` Vladimir Vid
2019-01-15 16:16   ` Andrew Lunn
2019-01-15 16:16     ` Andrew Lunn
2019-01-15 16:37     ` Gregory CLEMENT
2019-01-15 16:37       ` Gregory CLEMENT
2019-01-15 17:38 ` [PATCH v4] " Vladimir Vid
2019-01-15 17:38   ` Vladimir Vid
2019-01-18 15:45   ` Gregory CLEMENT
2019-01-18 15:45     ` Gregory CLEMENT
2019-01-24 15:54 ` Vladimir Vid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111174147.GG20924@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=luis.torres@methode.com \
    --cc=luka.perkov@sartura.hr \
    --cc=paul.arola@telus.com \
    --cc=scott.roberts@telus.com \
    --cc=vladimir.vid@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.