Re: [PATCH 3/3] firmware: imx: scu-pd: add fallback compatible string support

[Shawn Guo <shawnguo@kernel.org>]

On Tue, Dec 18, 2018 at 04:01:29PM +0000, Aisheng Dong wrote:
> SCU power domain can be used in the same way by IMX8QXP and IMX8QM SoCs.
> Make the driver support the fallback compatible string "fsl,scu-pd" to
> allow other SoCs to reuse the common part.
> 
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/firmware/imx/scu-pd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
> index 407245f..1aaae98 100644
> --- a/drivers/firmware/imx/scu-pd.c
> +++ b/drivers/firmware/imx/scu-pd.c
> @@ -321,6 +321,7 @@ static int imx_sc_pd_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id imx_sc_pd_match[] = {
> +	{ .compatible = "fsl,scu-pd", &imx8qxp_scu_pd},

As the fallback compatible, it makes more sense to put it at end of the
table.  I fixed it up and applied the series.

Shawn

>  	{ .compatible = "fsl,imx8qxp-scu-pd", &imx8qxp_scu_pd},
>  	{ /* sentinel */ }
>  };
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel