From: Daniel Vetter <daniel@ffwll.ch>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put
Date: Mon, 14 Jan 2019 10:05:56 +0000 [thread overview]
Message-ID: <20190114100556.GC10517@phenom.ffwll.local> (raw)
In-Reply-To: <3397932.PmTvevuZIG@phil>
On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote:
> Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> > The device node iterators perform an of_node_get on each iteration, so a
> > jump out of the loop requires an of_node_put.
> >
> > The semantic patch that fixes this problem is as follows
> > (http://coccinelle.lip6.fr):
> >
> > // <smpl>
> > @@
> > expression root,e;
> > local idexpression child;
> > iterator name for_each_child_of_node;
> > @@
> >
> > for_each_child_of_node(root, child) {
> > ... when != of_node_put(child)
> > when != e = child
> > + of_node_put(child);
> > ? break;
> > ...
> > }
> > ... when != child
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> I've added a fixes+stable tag and applied it to drm-misc-fixes
All of them or just this one here? These cleanup patches have a high
chance of falling through cracks, so taking them all usually works out
better ...
-Daniel
>
> Thanks for catching that
> Heiko
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put
Date: Mon, 14 Jan 2019 11:05:56 +0100 [thread overview]
Message-ID: <20190114100556.GC10517@phenom.ffwll.local> (raw)
In-Reply-To: <3397932.PmTvevuZIG@phil>
On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote:
> Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> > The device node iterators perform an of_node_get on each iteration, so a
> > jump out of the loop requires an of_node_put.
> >
> > The semantic patch that fixes this problem is as follows
> > (http://coccinelle.lip6.fr):
> >
> > // <smpl>
> > @@
> > expression root,e;
> > local idexpression child;
> > iterator name for_each_child_of_node;
> > @@
> >
> > for_each_child_of_node(root, child) {
> > ... when != of_node_put(child)
> > when != e = child
> > + of_node_put(child);
> > ? break;
> > ...
> > }
> > ... when != child
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> I've added a fixes+stable tag and applied it to drm-misc-fixes
All of them or just this one here? These cleanup patches have a high
chance of falling through cracks, so taking them all usually works out
better ...
-Daniel
>
> Thanks for catching that
> Heiko
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Julia Lawall <Julia.Lawall@lip6.fr>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put
Date: Mon, 14 Jan 2019 11:05:56 +0100 [thread overview]
Message-ID: <20190114100556.GC10517@phenom.ffwll.local> (raw)
In-Reply-To: <3397932.PmTvevuZIG@phil>
On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote:
> Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> > The device node iterators perform an of_node_get on each iteration, so a
> > jump out of the loop requires an of_node_put.
> >
> > The semantic patch that fixes this problem is as follows
> > (http://coccinelle.lip6.fr):
> >
> > // <smpl>
> > @@
> > expression root,e;
> > local idexpression child;
> > iterator name for_each_child_of_node;
> > @@
> >
> > for_each_child_of_node(root, child) {
> > ... when != of_node_put(child)
> > when != e = child
> > + of_node_put(child);
> > ? break;
> > ...
> > }
> > ... when != child
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> I've added a fixes+stable tag and applied it to drm-misc-fixes
All of them or just this one here? These cleanup patches have a high
chance of falling through cracks, so taking them all usually works out
better ...
-Daniel
>
> Thanks for catching that
> Heiko
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Sandy Huang <hjc@rock-chips.com>,
kernel-janitors@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put
Date: Mon, 14 Jan 2019 11:05:56 +0100 [thread overview]
Message-ID: <20190114100556.GC10517@phenom.ffwll.local> (raw)
In-Reply-To: <3397932.PmTvevuZIG@phil>
On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote:
> Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> > The device node iterators perform an of_node_get on each iteration, so a
> > jump out of the loop requires an of_node_put.
> >
> > The semantic patch that fixes this problem is as follows
> > (http://coccinelle.lip6.fr):
> >
> > // <smpl>
> > @@
> > expression root,e;
> > local idexpression child;
> > iterator name for_each_child_of_node;
> > @@
> >
> > for_each_child_of_node(root, child) {
> > ... when != of_node_put(child)
> > when != e = child
> > + of_node_put(child);
> > ? break;
> > ...
> > }
> > ... when != child
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> I've added a fixes+stable tag and applied it to drm-misc-fixes
All of them or just this one here? These cleanup patches have a high
chance of falling through cracks, so taking them all usually works out
better ...
-Daniel
>
> Thanks for catching that
> Heiko
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-01-14 10:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 8:47 [PATCH 0/4] add missing of_node_puts Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` [PATCH 1/4] drm/mediatek: " Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` [PATCH 2/4] drm/imx: imx-ldb: " Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-17 14:00 ` Philipp Zabel
2019-01-17 14:00 ` Philipp Zabel
2019-01-13 8:47 ` [PATCH 3/4] drm/rockchip: add missing of_node_put Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 18:48 ` Heiko Stuebner
2019-01-13 18:48 ` Heiko Stuebner
2019-01-13 18:48 ` Heiko Stuebner
2019-01-13 18:48 ` Heiko Stuebner
2019-01-14 10:05 ` Daniel Vetter [this message]
2019-01-14 10:05 ` Daniel Vetter
2019-01-14 10:05 ` Daniel Vetter
2019-01-14 10:05 ` Daniel Vetter
2019-01-14 10:09 ` Heiko Stuebner
2019-01-14 10:09 ` Heiko Stuebner
2019-01-14 10:09 ` Heiko Stuebner
2019-01-14 10:09 ` Heiko Stuebner
2019-01-13 8:47 ` [PATCH 4/4] drm/sun4i: backend: add missing of_node_puts Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-13 8:47 ` Julia Lawall
2019-01-16 8:59 ` Maxime Ripard
2019-01-16 8:59 ` Maxime Ripard
2019-01-16 8:59 ` Maxime Ripard
2019-01-16 8:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114100556.GC10517@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.