* [PATCH] watchdog: mt7621: Fix compiler error, missing include
@ 2019-01-14 21:17 René van Dorst
[not found] ` <20190114211719.11461-1-opensource-91nzXlUTePbQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: René van Dorst @ 2019-01-14 21:17 UTC (permalink / raw)
To: linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: René van Dorst
drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
static const struct of_device_id mt7621_wdt_match[] = {
^~~~~~~~~~~~~~~~
drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
{ .compatible = "mediatek,mt7621-wdt" },
^
drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
static const struct of_device_id mt7621_wdt_match[] = {
^~~~~~~~~~~~~~~~
Signed-off-by: René van Dorst <opensource@vdorst.com>
---
drivers/watchdog/mt7621_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
index 5c4a764717c4..a3be7db9d76f 100644
--- a/drivers/watchdog/mt7621_wdt.c
+++ b/drivers/watchdog/mt7621_wdt.c
@@ -16,6 +16,7 @@
#include <linux/kernel.h>
#include <linux/watchdog.h>
#include <linux/moduleparam.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <asm/mach-ralink/ralink_regs.h>
--
2.19.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
2019-01-14 21:17 [PATCH] watchdog: mt7621: Fix compiler error, missing include René van Dorst
@ 2019-01-15 15:16 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2019-01-15 15:16 UTC (permalink / raw)
To: René van Dorst, linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 14/01/2019 22:17, René van Dorst wrote:
> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
> { .compatible = "mediatek,mt7621-wdt" },
> ^
> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
>
Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.
Thanks,
Matthias
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> ---
> drivers/watchdog/mt7621_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 5c4a764717c4..a3be7db9d76f 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -16,6 +16,7 @@
> #include <linux/kernel.h>
> #include <linux/watchdog.h>
> #include <linux/moduleparam.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
@ 2019-01-15 15:16 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2019-01-15 15:16 UTC (permalink / raw)
To: René van Dorst, linux-watchdog, linux-mediatek
On 14/01/2019 22:17, René van Dorst wrote:
> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
> { .compatible = "mediatek,mt7621-wdt" },
> ^
> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
>
Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.
Thanks,
Matthias
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> ---
> drivers/watchdog/mt7621_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 5c4a764717c4..a3be7db9d76f 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -16,6 +16,7 @@
> #include <linux/kernel.h>
> #include <linux/watchdog.h>
> #include <linux/moduleparam.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
2019-01-15 15:16 ` Matthias Brugger
@ 2019-01-15 15:29 ` René van Dorst
-1 siblings, 0 replies; 5+ messages in thread
From: René van Dorst @ 2019-01-15 15:29 UTC (permalink / raw)
To: Matthias Brugger
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA
Quoting Matthias Brugger <matthias.bgg@gmail.com>:
> On 14/01/2019 22:17, René van Dorst wrote:
>> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has
>> incomplete element type 'struct of_device_id'
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in
>> record or union initializer
>> { .compatible = "mediatek,mt7621-wdt" },
>> ^
>> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for
>> 'mt7621_wdt_match')
>> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match'
>> defined but not used [-Wunused-variable]
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>>
>
> Did this work in the past?
> I suppose so. Could you provide a fixes tag for stable.
I see that I am not the first who spotted this.
https://patchwork.kernel.org/patch/10745049/
So better drop this one.
Greats,
René
> Thanks,
> Matthias
>
>> Signed-off-by: René van Dorst <opensource@vdorst.com>
>> ---
>> drivers/watchdog/mt7621_wdt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
>> index 5c4a764717c4..a3be7db9d76f 100644
>> --- a/drivers/watchdog/mt7621_wdt.c
>> +++ b/drivers/watchdog/mt7621_wdt.c
>> @@ -16,6 +16,7 @@
>> #include <linux/kernel.h>
>> #include <linux/watchdog.h>
>> #include <linux/moduleparam.h>
>> +#include <linux/of.h>
>> #include <linux/platform_device.h>
>>
>> #include <asm/mach-ralink/ralink_regs.h>
>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
@ 2019-01-15 15:29 ` René van Dorst
0 siblings, 0 replies; 5+ messages in thread
From: René van Dorst @ 2019-01-15 15:29 UTC (permalink / raw)
To: Matthias Brugger; +Cc: linux-watchdog, linux-mediatek
Quoting Matthias Brugger <matthias.bgg@gmail.com>:
> On 14/01/2019 22:17, René van Dorst wrote:
>> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has
>> incomplete element type 'struct of_device_id'
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in
>> record or union initializer
>> { .compatible = "mediatek,mt7621-wdt" },
>> ^
>> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for
>> 'mt7621_wdt_match')
>> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match'
>> defined but not used [-Wunused-variable]
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>>
>
> Did this work in the past?
> I suppose so. Could you provide a fixes tag for stable.
I see that I am not the first who spotted this.
https://patchwork.kernel.org/patch/10745049/
So better drop this one.
Greats,
René
> Thanks,
> Matthias
>
>> Signed-off-by: René van Dorst <opensource@vdorst.com>
>> ---
>> drivers/watchdog/mt7621_wdt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
>> index 5c4a764717c4..a3be7db9d76f 100644
>> --- a/drivers/watchdog/mt7621_wdt.c
>> +++ b/drivers/watchdog/mt7621_wdt.c
>> @@ -16,6 +16,7 @@
>> #include <linux/kernel.h>
>> #include <linux/watchdog.h>
>> #include <linux/moduleparam.h>
>> +#include <linux/of.h>
>> #include <linux/platform_device.h>
>>
>> #include <asm/mach-ralink/ralink_regs.h>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-15 15:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14 21:17 [PATCH] watchdog: mt7621: Fix compiler error, missing include René van Dorst
[not found] ` <20190114211719.11461-1-opensource-91nzXlUTePbQT0dZR+AlfA@public.gmane.org>
2019-01-15 15:16 ` Matthias Brugger
2019-01-15 15:16 ` Matthias Brugger
[not found] ` <a8b870f2-a50d-144e-cdca-b8a95d48846b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-15 15:29 ` René van Dorst
2019-01-15 15:29 ` René van Dorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.