* [PATCH] tracing: Replace kzalloc with kcalloc
@ 2019-01-15 4:34 Gustavo A. R. Silva
2019-01-15 21:12 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-15 4:34 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, Gustavo A. R. Silva
Replace kzalloc() function with its 2-factor argument form, kcalloc().
This patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
kernel/trace/trace_probe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 9962cb5da8ac..57f0cbaf9c58 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -429,7 +429,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
parg->count);
}
- code = tmp = kzalloc(sizeof(*code) * FETCH_INSN_MAX, GFP_KERNEL);
+ code = tmp = kcalloc(FETCH_INSN_MAX, sizeof(*code), GFP_KERNEL);
if (!code)
return -ENOMEM;
code[FETCH_INSN_MAX - 1].op = FETCH_OP_END;
@@ -501,7 +501,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
code->op = FETCH_OP_END;
/* Shrink down the code buffer */
- parg->code = kzalloc(sizeof(*code) * (code - tmp + 1), GFP_KERNEL);
+ parg->code = kcalloc(code - tmp + 1, sizeof(*code), GFP_KERNEL);
if (!parg->code)
ret = -ENOMEM;
else
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Replace kzalloc with kcalloc
2019-01-15 4:34 [PATCH] tracing: Replace kzalloc with kcalloc Gustavo A. R. Silva
@ 2019-01-15 21:12 ` Steven Rostedt
2019-01-15 21:16 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2019-01-15 21:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Ingo Molnar, linux-kernel
On Mon, 14 Jan 2019 22:34:08 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Replace kzalloc() function with its 2-factor argument form, kcalloc().
>
> This patch replaces cases of:
>
> kzalloc(a * b, gfp)
>
> with:
> kcalloc(a * b, gfp)
I think you meant:
kcalloc(a, b, gfp)
-- Steve
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> kernel/trace/trace_probe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..57f0cbaf9c58 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -429,7 +429,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
> parg->count);
> }
>
> - code = tmp = kzalloc(sizeof(*code) * FETCH_INSN_MAX, GFP_KERNEL);
> + code = tmp = kcalloc(FETCH_INSN_MAX, sizeof(*code), GFP_KERNEL);
> if (!code)
> return -ENOMEM;
> code[FETCH_INSN_MAX - 1].op = FETCH_OP_END;
> @@ -501,7 +501,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
> code->op = FETCH_OP_END;
>
> /* Shrink down the code buffer */
> - parg->code = kzalloc(sizeof(*code) * (code - tmp + 1), GFP_KERNEL);
> + parg->code = kcalloc(code - tmp + 1, sizeof(*code), GFP_KERNEL);
> if (!parg->code)
> ret = -ENOMEM;
> else
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Replace kzalloc with kcalloc
2019-01-15 21:12 ` Steven Rostedt
@ 2019-01-15 21:16 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-15 21:16 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, linux-kernel
On 1/15/19 3:12 PM, Steven Rostedt wrote:
> On Mon, 14 Jan 2019 22:34:08 -0600
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>
>> Replace kzalloc() function with its 2-factor argument form, kcalloc().
>>
>> This patch replaces cases of:
>>
>> kzalloc(a * b, gfp)
>>
>> with:
>> kcalloc(a * b, gfp)
>
> I think you meant:
>
> kcalloc(a, b, gfp)
>
Yep. copy/paste error. :/
Thanks
--
Gustavo
> -- Steve
>
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> kernel/trace/trace_probe.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
>> index 9962cb5da8ac..57f0cbaf9c58 100644
>> --- a/kernel/trace/trace_probe.c
>> +++ b/kernel/trace/trace_probe.c
>> @@ -429,7 +429,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
>> parg->count);
>> }
>>
>> - code = tmp = kzalloc(sizeof(*code) * FETCH_INSN_MAX, GFP_KERNEL);
>> + code = tmp = kcalloc(FETCH_INSN_MAX, sizeof(*code), GFP_KERNEL);
>> if (!code)
>> return -ENOMEM;
>> code[FETCH_INSN_MAX - 1].op = FETCH_OP_END;
>> @@ -501,7 +501,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
>> code->op = FETCH_OP_END;
>>
>> /* Shrink down the code buffer */
>> - parg->code = kzalloc(sizeof(*code) * (code - tmp + 1), GFP_KERNEL);
>> + parg->code = kcalloc(code - tmp + 1, sizeof(*code), GFP_KERNEL);
>> if (!parg->code)
>> ret = -ENOMEM;
>> else
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-15 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 4:34 [PATCH] tracing: Replace kzalloc with kcalloc Gustavo A. R. Silva
2019-01-15 21:12 ` Steven Rostedt
2019-01-15 21:16 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.