Regression in v5.0-rc with regmap-irq level-irq changes

Regression in v5.0-rc with regmap-irq level-irq changes

[Tony Lindgren]

Hi,

Looks like commit 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add
level-irq support") caused a regression at least with palmas PMIC where
child interrupt no longer work and we get something like this on
omap5-uevm for example:

genirq: Setting trigger mode 3 for irq 157 failed
(regmap_irq_set_type+0x0/0x15c)
genirq: Setting trigger mode 12 for irq 154 failed
(regmap_irq_set_type+0x0/0x15c)
genirq: Setting trigger mode 8 for irq 149 failed
(regmap_irq_set_type+0x0/0x15c)

These are for child devices like power button, USB and RTC interrupts.
I'd also assume GPIOs might be broken now.

Any ideas what's needed? Some triggering mapping data to palmas.c
driver?

To me it seems the child device interrupt triggering can be whatever
the hardware supports including IRQ_TYPE_NONE for non-configurable
interrupts. Additionally palmas.c supports inverting the SoC
interrupt also.

Not sure if other things are broken now too, it might be worth
grepping the logs at kernelci.org for similar genirq errors above?

Regards,

Tony

Regression in v5.0-rc with regmap-irq level-irq changes

[Tony Lindgren]

Hi,

Looks like commit 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add
level-irq support") caused a regression at least with palmas PMIC where
child interrupt no longer work and we get something like this on
omap5-uevm for example:

genirq: Setting trigger mode 3 for irq 157 failed
(regmap_irq_set_type+0x0/0x15c)
genirq: Setting trigger mode 12 for irq 154 failed
(regmap_irq_set_type+0x0/0x15c)
genirq: Setting trigger mode 8 for irq 149 failed
(regmap_irq_set_type+0x0/0x15c)

These are for child devices like power button, USB and RTC interrupts.
I'd also assume GPIOs might be broken now.

Any ideas what's needed? Some triggering mapping data to palmas.c
driver?

To me it seems the child device interrupt triggering can be whatever
the hardware supports including IRQ_TYPE_NONE for non-configurable
interrupts. Additionally palmas.c supports inverting the SoC
interrupt also.

Not sure if other things are broken now too, it might be worth
grepping the logs at kernelci.org for similar genirq errors above?

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:

> Any ideas what's needed? Some triggering mapping data to palmas.c
> driver?

There should be a fix in -next already waiting for me to send it to
Linus, can you check there (a couple actually, in my for-linus branch)?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:

> Any ideas what's needed? Some triggering mapping data to palmas.c
> driver?

There should be a fix in -next already waiting for me to send it to
Linus, can you check there (a couple actually, in my for-linus branch)?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Tony Lindgren]

* Mark Brown <broonie@kernel.org> [190115 21:09]:
> On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:
> 
> > Any ideas what's needed? Some triggering mapping data to palmas.c
> > driver?
> 
> There should be a fix in -next already waiting for me to send it to
> Linus, can you check there (a couple actually, in my for-linus branch)?

OK great, yes the two drivers/base/regmap patches fix the issue
for me.

Regards,

Tony

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Tony Lindgren]

* Mark Brown <broonie@kernel.org> [190115 21:09]:
> On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:
> 
> > Any ideas what's needed? Some triggering mapping data to palmas.c
> > driver?
> 
> There should be a fix in -next already waiting for me to send it to
> Linus, can you check there (a couple actually, in my for-linus branch)?

OK great, yes the two drivers/base/regmap patches fix the issue
for me.

Regards,

Tony


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Tue, Jan 15, 2019 at 04:10:25PM -0800, Tony Lindgren wrote:
> * Mark Brown <broonie@kernel.org> [190115 21:09]:
> > On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:

> > > Any ideas what's needed? Some triggering mapping data to palmas.c
> > > driver?

> > There should be a fix in -next already waiting for me to send it to
> > Linus, can you check there (a couple actually, in my for-linus branch)?

> OK great, yes the two drivers/base/regmap patches fix the issue
> for me.

Excellent, thanks for testing - I'm aiming to send them off this week, I
was going to send them off earlier but then the second fix came in.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Regression in v5.0-rc with regmap-irq level-irq changes

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 637 bytes --]

On Tue, Jan 15, 2019 at 04:10:25PM -0800, Tony Lindgren wrote:
> * Mark Brown <broonie@kernel.org> [190115 21:09]:
> > On Tue, Jan 15, 2019 at 11:28:40AM -0800, Tony Lindgren wrote:

> > > Any ideas what's needed? Some triggering mapping data to palmas.c
> > > driver?

> > There should be a fix in -next already waiting for me to send it to
> > Linus, can you check there (a couple actually, in my for-linus branch)?

> OK great, yes the two drivers/base/regmap patches fix the issue
> for me.

Excellent, thanks for testing - I'm aiming to send them off this week, I
was going to send them off earlier but then the second fix came in.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel