From: Rob Herring <robh@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Joel Stanley" <joel@jms.id.au>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, "Sam Ravnborg" <sam@ravnborg.org>,
"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH v2 2/5] dt-binding: pcf8523: add xtal load capacitance
Date: Tue, 15 Jan 2019 15:06:57 -0600 [thread overview]
Message-ID: <20190115210657.GA24662@bogus> (raw)
In-Reply-To: <20190108185414.26922-3-sam@ravnborg.org>
On Tue, 8 Jan 2019 19:54:11 +0100, Sam Ravnborg wrote:
> The NXP pcf8523 supports two different xtal load capacitance
> - 7000fF (7pF) HW default
> - 12500fF (12.5pF) Minimum power consumption, driver default
>
> To obtain a precise RTC the pcf8523 must be configured
> with the correct capacitance load of the xtal.
>
> Add a property to specify the xtal capacitance load.
> The default value matches that of the current Linux driver.
>
> With a dedicated binding remove the entry in rtc.txt
>
> Signed-off-by: Søren Andersen <san@skov.dk>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 18 ++++++++++++++++++
> Documentation/devicetree/bindings/rtc/rtc.txt | 1 -
> 2 files changed, 18 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Joel Stanley" <joel@jms.id.au>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, "Sam Ravnborg" <sam@ravnborg.org>,
"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH v2 2/5] dt-binding: pcf8523: add xtal load capacitance
Date: Tue, 15 Jan 2019 15:06:57 -0600 [thread overview]
Message-ID: <20190115210657.GA24662@bogus> (raw)
In-Reply-To: <20190108185414.26922-3-sam@ravnborg.org>
On Tue, 8 Jan 2019 19:54:11 +0100, Sam Ravnborg wrote:
> The NXP pcf8523 supports two different xtal load capacitance
> - 7000fF (7pF) HW default
> - 12500fF (12.5pF) Minimum power consumption, driver default
>
> To obtain a precise RTC the pcf8523 must be configured
> with the correct capacitance load of the xtal.
>
> Add a property to specify the xtal capacitance load.
> The default value matches that of the current Linux driver.
>
> With a dedicated binding remove the entry in rtc.txt
>
> Signed-off-by: Søren Andersen <san@skov.dk>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 18 ++++++++++++++++++
> Documentation/devicetree/bindings/rtc/rtc.txt | 1 -
> 2 files changed, 18 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-01-15 21:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 18:54 [PATCH v2 0/5] add quartz load support to NXP rtc drivers Sam Ravnborg
2019-01-08 18:54 ` [PATCH v2 1/5] devicetree: property-units: Add femtofarads unit Sam Ravnborg
2019-01-15 21:04 ` Rob Herring
2019-01-15 21:04 ` Rob Herring
2019-01-08 18:54 ` [PATCH v2 2/5] dt-binding: pcf8523: add xtal load capacitance Sam Ravnborg
2019-01-15 21:06 ` Rob Herring [this message]
2019-01-15 21:06 ` Rob Herring
2019-01-08 18:54 ` [PATCH v2 3/5] dt-binding: pcf85063: " Sam Ravnborg
2019-01-15 21:08 ` Rob Herring
2019-01-15 22:22 ` Sam Ravnborg
2019-01-08 18:54 ` [PATCH v2 4/5] rtc: pcf8523: set xtal load capacitance from DT Sam Ravnborg
2019-01-16 21:04 ` Alexandre Belloni
2019-01-08 18:54 ` [PATCH v2 5/5] rtc: pcf85063: " Sam Ravnborg
2019-01-16 21:11 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115210657.GA24662@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sam@ravnborg.org \
--cc=san@skov.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.