All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, a.tropschug@ebs-systart.com,
	m.bittner@ebs-systart.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Amit Kucheria <amit.kucheria@linaro.org>,
	Yang-Leo Li <leoyang.li@nxp.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis
Date: Wed, 16 Jan 2019 18:14:43 +0800	[thread overview]
Message-ID: <20190116101441.GH15808@dragon> (raw)
In-Reply-To: <CAL_Jsq+myeZ1n4X=KhHZjtPDHnGH=L65xxYbzMrt8Rq6Bur4Bg@mail.gmail.com>

On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote:
> On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote:
> > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam
> > > <manivannan.sadhasivam@linaro.org> wrote:
> > > >
> > > > Add devicetree binding for Oxalis board in JSON format. While adding
> > > > that, let's fix the description for LS1012A also.
> > > >
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > index d34fe0749199..0f30142fe316 100644
> > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > @@ -173,12 +173,13 @@ properties:
> > > >                - fsl,vf610
> > > >                - fsl,vf610m4
> > > >
> > > > -      - description: LS1021A based Boards
> > > > +      - description: LS1012A based Boards
> > >
> > > Well, yes that was wrong...
> > >
> > > >          items:
> > > >            - enum:
> > > >                - fsl,ls1012a-rdb
> > > >                - fsl,ls1012a-frdm
> > > >                - fsl,ls1012a-qds
> > > > +              - ebs-systart,oxalis
> > >
> > > Sort alphabetically.
> > >
> > > >            - const: fsl,ls1021a
> > >
> > > And this is wrong too.
> > >
> > > I you just change it, then we will be missing an entry for LS1021A.
> > > What's the status of that SoC because there is no board dts file? We
> > > should not have .dtsi files in the kernel which don't get built.
> >
> > Hmm, I do not see any LS1021A SoC .dtsi in the tree.  I suspect it's
> > just a typo of LS1012A.
> >
> > @Leo, do we have a LS1021A SoC?
> 
> arch/arm/boot/dts/ls1021a.dtsi

Oops, I only searched arm64 folder.

So it seems the compatible of the boards below are missing there.

  ls1021a-moxa-uc-8410a.dts
  ls1021a-qds.dts
  ls1021a-twr.dts

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Yang-Leo Li <leoyang.li@nxp.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	a.tropschug@ebs-systart.com, m.bittner@ebs-systart.com,
	Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis
Date: Wed, 16 Jan 2019 18:14:43 +0800	[thread overview]
Message-ID: <20190116101441.GH15808@dragon> (raw)
In-Reply-To: <CAL_Jsq+myeZ1n4X=KhHZjtPDHnGH=L65xxYbzMrt8Rq6Bur4Bg@mail.gmail.com>

On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote:
> On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote:
> > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam
> > > <manivannan.sadhasivam@linaro.org> wrote:
> > > >
> > > > Add devicetree binding for Oxalis board in JSON format. While adding
> > > > that, let's fix the description for LS1012A also.
> > > >
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > index d34fe0749199..0f30142fe316 100644
> > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > @@ -173,12 +173,13 @@ properties:
> > > >                - fsl,vf610
> > > >                - fsl,vf610m4
> > > >
> > > > -      - description: LS1021A based Boards
> > > > +      - description: LS1012A based Boards
> > >
> > > Well, yes that was wrong...
> > >
> > > >          items:
> > > >            - enum:
> > > >                - fsl,ls1012a-rdb
> > > >                - fsl,ls1012a-frdm
> > > >                - fsl,ls1012a-qds
> > > > +              - ebs-systart,oxalis
> > >
> > > Sort alphabetically.
> > >
> > > >            - const: fsl,ls1021a
> > >
> > > And this is wrong too.
> > >
> > > I you just change it, then we will be missing an entry for LS1021A.
> > > What's the status of that SoC because there is no board dts file? We
> > > should not have .dtsi files in the kernel which don't get built.
> >
> > Hmm, I do not see any LS1021A SoC .dtsi in the tree.  I suspect it's
> > just a typo of LS1012A.
> >
> > @Leo, do we have a LS1021A SoC?
> 
> arch/arm/boot/dts/ls1021a.dtsi

Oops, I only searched arm64 folder.

So it seems the compatible of the boards below are missing there.

  ls1021a-moxa-uc-8410a.dts
  ls1021a-qds.dts
  ls1021a-twr.dts

Shawn

  reply	other threads:[~2019-01-16 10:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam
2019-01-14 10:20 ` Manivannan Sadhasivam
2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam
2019-01-14 10:20   ` Manivannan Sadhasivam
2019-01-16 21:10   ` Rob Herring
2019-01-16 21:10     ` Rob Herring
2019-01-16 21:10     ` Rob Herring
2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam
2019-01-14 10:20   ` Manivannan Sadhasivam
2019-01-14 18:02   ` Rob Herring
2019-01-14 18:02     ` Rob Herring
2019-01-14 18:10     ` Manivannan Sadhasivam
2019-01-14 18:10       ` Manivannan Sadhasivam
2019-01-16  2:21     ` Shawn Guo
2019-01-16  2:21       ` Shawn Guo
2019-01-16  4:07       ` Rob Herring
2019-01-16  4:07         ` Rob Herring
2019-01-16 10:14         ` Shawn Guo [this message]
2019-01-16 10:14           ` Shawn Guo
2019-01-21  6:09           ` Manivannan Sadhasivam
2019-01-21  6:09             ` Manivannan Sadhasivam
2019-01-21  6:09             ` Manivannan Sadhasivam
2019-01-21 19:57             ` Leo Li
2019-01-21 19:57               ` Leo Li
2019-01-22  3:00               ` Shawn Guo
2019-01-22  3:00                 ` Shawn Guo
2019-01-14 10:20 ` [PATCH v2 3/3] arm64: dts: freescale: Add devicetree " Manivannan Sadhasivam
2019-01-14 10:20   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116101441.GH15808@dragon \
    --to=shawnguo@kernel.org \
    --cc=a.tropschug@ebs-systart.com \
    --cc=amit.kucheria@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.bittner@ebs-systart.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.