* linux-next: Fixes tag needs some work in the drm-misc tree
@ 2019-01-16 21:13 Stephen Rothwell
2019-01-16 21:45 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-01-16 21:13 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics, DRI
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sam Ravnborg,
Paul Gortmaker
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
[I am experimenting with checking the Fixes tags in commits in linux-next.
Please let me know if you think I am being too strict.]
Hi all,
Commit
94520db52fc0 ("drm: fix alpha build after drm_util.h change")
has a malformed Fixes tag:
Fixes: 733748ac37b45 ("drm: move drm_can_sleep() to drm_util.h")
The SHA1 does not reference a commit currently in the tree. Maybe it
was meant to be e9eafcb58921.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: Fixes tag needs some work in the drm-misc tree
2019-01-16 21:13 linux-next: Fixes tag needs some work in the drm-misc tree Stephen Rothwell
@ 2019-01-16 21:45 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2019-01-16 21:45 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Daniel Vetter, Intel Graphics, Linux Kernel Mailing List, DRI,
Paul Gortmaker, Linux Next Mailing List
Hi all.
> Commit
>
> 94520db52fc0 ("drm: fix alpha build after drm_util.h change")
>
> has a malformed Fixes tag:
>
> Fixes: 733748ac37b45 ("drm: move drm_can_sleep() to drm_util.h")
>
> The SHA1 does not reference a commit currently in the tree. Maybe it
> was meant to be e9eafcb58921.
I can confirm that Stephen is right and that e9eafcb58921 is the proper SHA-1.
I guess the SHA-1 I used was from a rebased tree.
The mails from 0-DAY used the correct SHA-1 - which should have been a hint to me.
Sigh
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: Fixes tag needs some work in the drm-misc tree
@ 2019-01-16 21:45 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2019-01-16 21:45 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Daniel Vetter, Intel Graphics, DRI, Linux Next Mailing List,
Linux Kernel Mailing List, Paul Gortmaker
Hi all.
> Commit
>
> 94520db52fc0 ("drm: fix alpha build after drm_util.h change")
>
> has a malformed Fixes tag:
>
> Fixes: 733748ac37b45 ("drm: move drm_can_sleep() to drm_util.h")
>
> The SHA1 does not reference a commit currently in the tree. Maybe it
> was meant to be e9eafcb58921.
I can confirm that Stephen is right and that e9eafcb58921 is the proper SHA-1.
I guess the SHA-1 I used was from a rebased tree.
The mails from 0-DAY used the correct SHA-1 - which should have been a hint to me.
Sigh
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-16 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 21:13 linux-next: Fixes tag needs some work in the drm-misc tree Stephen Rothwell
2019-01-16 21:45 ` Sam Ravnborg
2019-01-16 21:45 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.