From: tycho at tycho.ws (Tycho Andersen)
Subject: Linux 5.0-rc2 seccomp_bpf user_notification_basic test hangs
Date: Thu, 17 Jan 2019 09:45:31 -0700 [thread overview]
Message-ID: <20190117164531.GD17449@cisco> (raw)
In-Reply-To: <CAGXu5jJOGO1UWdYdGmnnUEZOm-DaMUqR3UVSi+gnSc7q3KE8xA@mail.gmail.com>
On Thu, Jan 17, 2019 at 08:41:59AM -0800, Kees Cook wrote:
> On Thu, Jan 17, 2019 at 8:27 AM Tycho Andersen <tycho at tycho.ws> wrote:
> >
> > On Thu, Jan 17, 2019 at 08:12:50AM -0800, Kees Cook wrote:
> > > On Wed, Jan 16, 2019 at 5:26 PM shuah <shuah at kernel.org> wrote:
> > > > I am running Linux 5.0-rc2 and not an older kernel.
> > >
> > > Weird. I couldn't reproduce this on 5.0-rc2, but I did see it on a
> > > kernel without seccomp user_notif. Does the patch I sent fix it for
> > > you? (And if so, can you take it in your tree?)
> >
> > I can reproduce it; you have to run it as non-root. I think your patch
> > is necessary to get it to at least fail. The question is: what should
> > we do about these tests that require real root? Skip them if we're not
> > real-root, I guess?
>
> Hm, maybe use the XFAIL() bit of the harness?
>
> Perhaps it's time to make it a root-only test and do internal
> priv-dropping to test the nnp-requiring parts? I'll add it to the TODO
> list...
Ok, I'll try to send a couple of patches soon to fix some of this up.
But at least yours should should stop things from hanging for now.
Thanks,
Tycho
WARNING: multiple messages have this Message-ID (diff)
From: tycho@tycho.ws (Tycho Andersen)
Subject: Linux 5.0-rc2 seccomp_bpf user_notification_basic test hangs
Date: Thu, 17 Jan 2019 09:45:31 -0700 [thread overview]
Message-ID: <20190117164531.GD17449@cisco> (raw)
Message-ID: <20190117164531.1it59DGCY8CaouH_0U8Adx3FnDTc_1HKh3YZ8bKVyNg@z> (raw)
In-Reply-To: <CAGXu5jJOGO1UWdYdGmnnUEZOm-DaMUqR3UVSi+gnSc7q3KE8xA@mail.gmail.com>
On Thu, Jan 17, 2019@08:41:59AM -0800, Kees Cook wrote:
> On Thu, Jan 17, 2019@8:27 AM Tycho Andersen <tycho@tycho.ws> wrote:
> >
> > On Thu, Jan 17, 2019@08:12:50AM -0800, Kees Cook wrote:
> > > On Wed, Jan 16, 2019@5:26 PM shuah <shuah@kernel.org> wrote:
> > > > I am running Linux 5.0-rc2 and not an older kernel.
> > >
> > > Weird. I couldn't reproduce this on 5.0-rc2, but I did see it on a
> > > kernel without seccomp user_notif. Does the patch I sent fix it for
> > > you? (And if so, can you take it in your tree?)
> >
> > I can reproduce it; you have to run it as non-root. I think your patch
> > is necessary to get it to at least fail. The question is: what should
> > we do about these tests that require real root? Skip them if we're not
> > real-root, I guess?
>
> Hm, maybe use the XFAIL() bit of the harness?
>
> Perhaps it's time to make it a root-only test and do internal
> priv-dropping to test the nnp-requiring parts? I'll add it to the TODO
> list...
Ok, I'll try to send a couple of patches soon to fix some of this up.
But at least yours should should stop things from hanging for now.
Thanks,
Tycho
WARNING: multiple messages have this Message-ID (diff)
From: Tycho Andersen <tycho@tycho.ws>
To: Kees Cook <keescook@chromium.org>
Cc: shuah <shuah@kernel.org>, James Morris <jmorris@namei.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: Linux 5.0-rc2 seccomp_bpf user_notification_basic test hangs
Date: Thu, 17 Jan 2019 09:45:31 -0700 [thread overview]
Message-ID: <20190117164531.GD17449@cisco> (raw)
In-Reply-To: <CAGXu5jJOGO1UWdYdGmnnUEZOm-DaMUqR3UVSi+gnSc7q3KE8xA@mail.gmail.com>
On Thu, Jan 17, 2019 at 08:41:59AM -0800, Kees Cook wrote:
> On Thu, Jan 17, 2019 at 8:27 AM Tycho Andersen <tycho@tycho.ws> wrote:
> >
> > On Thu, Jan 17, 2019 at 08:12:50AM -0800, Kees Cook wrote:
> > > On Wed, Jan 16, 2019 at 5:26 PM shuah <shuah@kernel.org> wrote:
> > > > I am running Linux 5.0-rc2 and not an older kernel.
> > >
> > > Weird. I couldn't reproduce this on 5.0-rc2, but I did see it on a
> > > kernel without seccomp user_notif. Does the patch I sent fix it for
> > > you? (And if so, can you take it in your tree?)
> >
> > I can reproduce it; you have to run it as non-root. I think your patch
> > is necessary to get it to at least fail. The question is: what should
> > we do about these tests that require real root? Skip them if we're not
> > real-root, I guess?
>
> Hm, maybe use the XFAIL() bit of the harness?
>
> Perhaps it's time to make it a root-only test and do internal
> priv-dropping to test the nnp-requiring parts? I'll add it to the TODO
> list...
Ok, I'll try to send a couple of patches soon to fix some of this up.
But at least yours should should stop things from hanging for now.
Thanks,
Tycho
next prev parent reply other threads:[~2019-01-17 16:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 0:01 Linux 5.0-rc2 seccomp_bpf user_notification_basic test hangs shuah
2019-01-17 0:01 ` shuah
2019-01-17 0:01 ` shuah
2019-01-17 0:30 ` keescook
2019-01-17 0:30 ` Kees Cook
2019-01-17 0:30 ` Kees Cook
2019-01-17 0:44 ` tycho
2019-01-17 0:44 ` Tycho Andersen
2019-01-17 0:44 ` Tycho Andersen
2019-01-17 1:26 ` shuah
2019-01-17 1:26 ` shuah
2019-01-17 1:26 ` shuah
2019-01-17 16:12 ` keescook
2019-01-17 16:12 ` Kees Cook
2019-01-17 16:12 ` Kees Cook
2019-01-17 16:27 ` tycho
2019-01-17 16:27 ` Tycho Andersen
2019-01-17 16:27 ` Tycho Andersen
2019-01-17 16:41 ` keescook
2019-01-17 16:41 ` Kees Cook
2019-01-17 16:41 ` Kees Cook
2019-01-17 16:45 ` tycho [this message]
2019-01-17 16:45 ` Tycho Andersen
2019-01-17 16:45 ` Tycho Andersen
2019-01-17 17:53 ` shuah
2019-01-17 17:53 ` shuah
2019-01-17 17:53 ` shuah
2019-01-17 16:11 ` keescook
2019-01-17 16:11 ` Kees Cook
2019-01-17 16:11 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117164531.GD17449@cisco \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.