From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v4.9.y] proc: Remove empty line in /proc/self/status
Date: Fri, 18 Jan 2019 17:10:48 +0100 [thread overview]
Message-ID: <20190118161048.GF11503@kroah.com> (raw)
In-Reply-To: <1547665111-31650-1-git-send-email-linux@roeck-us.net>
On Wed, Jan 16, 2019 at 10:58:31AM -0800, Guenter Roeck wrote:
> If CONFIG_SECCOMP=n, /proc/self/status includes an empty line. This causes
> the iotop application to bail out with an error message.
>
> File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line 196,
> in parse_proc_pid_status
> key, value = line.split(':\t', 1)
> ValueError: need more than 1 value to unpack
>
> The problem is seen in v4.9.y but not upstream because commit af884cd4a5ae6
> ("proc: report no_new_privs state") has not been backported to v4.9.y.
> The backport of commit fae1fa0fc6cc ("proc: Provide details on speculation
> flaw mitigations") tried to address the resulting differences but was
> wrong, introducing the problem.
>
> Fixes: 51ef9af2a35b ("proc: Provide details on speculation flaw mitigations")
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> This patch only applies to v4.9.y. v4.4.y also needs to be fixed (see
> https://www.spinics.net/lists/stable/msg279131.html), but the fix
> is slightly different. v4.14.y and later are not affected.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-01-18 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 18:58 [PATCH v4.9.y] proc: Remove empty line in /proc/self/status Guenter Roeck
2019-01-16 19:03 ` Kees Cook
2019-01-18 16:10 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118161048.GF11503@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gwendal@chromium.org \
--cc=keescook@chromium.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.